Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbdFTJ1j (ORCPT ); Tue, 20 Jun 2017 05:27:39 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34484 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbdFTJ1f (ORCPT ); Tue, 20 Jun 2017 05:27:35 -0400 Date: Tue, 20 Jun 2017 17:26:11 +0800 From: Dong Aisheng To: Stephen Boyd Cc: Dong Aisheng , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mturquette@baylibre.com, shawnguo@kernel.org, Anson.Huang@nxp.com, ping.bai@nxp.com Subject: Re: [PATCH 3/9] clk: fractional-divider: add CLK_FRAC_DIVIDER_ZERO_BASED flag support Message-ID: <20170620092611.GC6805@b29396-OptiPlex-7040> References: <1494856763-6543-1-git-send-email-aisheng.dong@nxp.com> <1494856763-6543-4-git-send-email-aisheng.dong@nxp.com> <20170620015547.GN4493@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620015547.GN4493@codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1343 Lines: 38 On Mon, Jun 19, 2017 at 06:55:47PM -0700, Stephen Boyd wrote: > On 05/15, Dong Aisheng wrote: > > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h > > index a6efbb9..4466cae 100644 > > --- a/include/linux/clk-provider.h > > +++ b/include/linux/clk-provider.h > > @@ -557,6 +557,11 @@ void clk_hw_unregister_fixed_factor(struct clk_hw *hw); > > * @lock: register lock > > * > > * Clock with adjustable fractional divider affecting its output frequency. > > + * > > + * Flags: > > + * CLK_FRAC_DIVIDER_ZERO_BASED - by default the divisor is the value read > > + * from the register. If CLK_FRAC_DIVIDER_ZERO_BASED is set then the > > + * divider is the raw value read from the register plus one. > > This should say the numerator and denominator are both the value > read plus one. It isn't clear if it applies to the numerator, or > the denominator, or both. > Good suggestion. Will improve it. Regards Dong Aisheng > > */ > > struct clk_fractional_divider { > > struct clk_hw hw; > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > -- > To unsubscribe from this list: send the line "unsubscribe linux-clk" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html