Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbdFTKDz (ORCPT ); Tue, 20 Jun 2017 06:03:55 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:45982 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbdFTKDw (ORCPT ); Tue, 20 Jun 2017 06:03:52 -0400 Date: Tue, 20 Jun 2017 12:03:48 +0200 From: Alexandre Belloni To: Benjamin Gaignard Cc: linaro-kernel@lists.linaro.org, adi-buildroot-devel@lists.sourceforge.net, Alessandro Zummo , Gregory Clement , Ingo Molnar , Jason Cooper , John Stultz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Michael Chan , netdev@vger.kernel.org, rtc-linux@googlegroups.com, Sebastian Hesselbarth , Support Opensource , Thomas Gleixner , x86@kernel.org, Baruch Siach , Hans Ulli Kroll , Vladimir Zapolskiy , Sylvain Lemieux , Barry Song , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org, patches@opensource.wolfsonmicro.com, "Rafael J. Wysocki" , Pavel Machek , Len Brown , linux-pm@vger.kernel.org Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Message-ID: <20170620100348.zh4ygvjjgnhxvmvl@piout.net> References: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 8574 Lines: 170 On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > rely on 32bits variables and that will make rtc break in y2038/2016. Please don't, because this hide the fact that the hardware will not handle dates in y2038 anyway and as pointed by Russell a few month ago, rtc_time_to_tm will be able to catch it but the 64 bit version will silently ignore it. > The goal of this series of patches is ti stop using those two functions > and use instead to safer 64bits ones. > > It also remove change .set_mmss to set_mmss64 callback for the same reasons. > > Those 51 patches almost clean all the drivers except the few that I haven't > been able to compile because of cross-toolchains issues (au1xxx, mpc5121, ps3, > puv3, sun4v, tx4939, starfire, ls1x ...) > > Obviously I don't have all those hardwares in my hands so I have only check > that the patches compile without warnings but it up to each maintainer to > valid them on real hardware. > > Benjamin Gaignard (51): > x86: rtc: stop using rtc deprecated functions > x86: intel-mid: vrtc: stop using rtc deprecated functions > net: broadcom: stop using rtc deprecated functions > rtc: 88pm80x: stop using rtc deprecated functions > rtc: 88pm860x: stop using rtc deprecated functions > rtc: ab-b5ze-s3: stop using rtc deprecated functions > rtc: ab8500: stop using rtc deprecated functions > rtc: armada38x: stop using rtc deprecated functions > rtc: at32ap700x: stop using rtc deprecated functions > rtc: at91sam9: stop using rtc deprecated functions > rtc: bfin: stop using rtc deprecated functions > rtc: coh901331: stop using rtc deprecated functions > rtc: cpcap: stop using rtc deprecated functions > rtc: da9063: stop using rtc deprecated functions > rtc: da9063: stop using rtc deprecated functions > rtc: davinci: stop using rtc deprecated functions > rtc: digicolor: stop using rtc deprecated functions > rtc: dm355evm: stop using rtc deprecated functions > rtc: ds1305: stop using rtc deprecated functions > rtc: ds1374: stop using rtc deprecated functions > rtc: ds1511: stop using rtc deprecated functions > rtc: ds1553: stop using rtc deprecated functions > rtc: ds1672: stop using rtc deprecated functions > rtc: ds2404: stop using rtc deprecated functions > rtc: ep93xx: stop using rtc deprecated functions > rtc: gemini: stop using rtc deprecated functions > rtc: imxdi: stop using rtc deprecated functions > rtc: jz4740: stop using rtc deprecated functions > rtc: lpc32xx: stop using rtc deprecated functions > rtc: mv: stop using rtc deprecated functions > rtc: omap: stop using rtc deprecated functions > rtc: pcap: stop using rtc deprecated functions > rtc: pl030: stop using rtc deprecated functions > rtc: pl031: stop using rtc deprecated functions > rtc: pm8xxx: stop using rtc deprecated functions > rtc: rs5c348: stop using rtc deprecated functions > rtc: sa1100: stop using rtc deprecated functions > rtc: sh: stop using rtc deprecated functions > rtc: sirfsoc: stop using rtc deprecated functions > rtc: snvs: stop using rtc deprecated functions > rtc: stk17ta8: stop using rtc deprecated functions > rtc: stmp3xxx: stop using rtc deprecated functions > rtc: sun6i: stop using rtc deprecated functions > rtc: sysfs: stop using rtc deprecated functions > rtc: tegra stop using rtc deprecated functions > rtc: test: stop using rtc deprecated functions > rtc: tps6586: stop using rtc deprecated functions > rtc: vr41xx: stop using rtc deprecated functions > rtc: wm831x: stop using rtc deprecated functions > rtc: xgene stop using rtc deprecated functions > power: suspend test: stop using rtc deprecated functions > > arch/x86/kernel/rtc.c | 6 ++-- > arch/x86/platform/intel-mid/intel_mid_vrtc.c | 2 +- > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- > drivers/rtc/rtc-88pm80x.c | 44 +++++++++++++-------------- > drivers/rtc/rtc-88pm860x.c | 40 ++++++++++++------------- > drivers/rtc/rtc-ab-b5ze-s3.c | 45 ++++++++-------------------- > drivers/rtc/rtc-ab8500.c | 26 ++++++++-------- > drivers/rtc/rtc-armada38x.c | 34 +++++++++------------ > drivers/rtc/rtc-at32ap700x.c | 29 ++++++++---------- > drivers/rtc/rtc-at91sam9.c | 18 ++++------- > drivers/rtc/rtc-bfin.c | 24 +++++++-------- > drivers/rtc/rtc-coh901331.c | 14 +++++---- > drivers/rtc/rtc-cpcap.c | 8 ++--- > drivers/rtc/rtc-da9052.c | 8 ++--- > drivers/rtc/rtc-da9063.c | 8 ++--- > drivers/rtc/rtc-davinci.c | 8 ++--- > drivers/rtc/rtc-digicolor.c | 4 +-- > drivers/rtc/rtc-dm355evm.c | 6 ++-- > drivers/rtc/rtc-ds1305.c | 11 +++---- > drivers/rtc/rtc-ds1374.c | 6 ++-- > drivers/rtc/rtc-ds1511.c | 2 +- > drivers/rtc/rtc-ds1553.c | 2 +- > drivers/rtc/rtc-ds1672.c | 8 ++--- > drivers/rtc/rtc-ds2404.c | 8 ++--- > drivers/rtc/rtc-ep93xx.c | 10 +++---- > drivers/rtc/rtc-gemini.c | 8 ++--- > drivers/rtc/rtc-imxdi.c | 16 +++++----- > drivers/rtc/rtc-jz4740.c | 12 ++++---- > drivers/rtc/rtc-lpc32xx.c | 19 +++++------- > drivers/rtc/rtc-mv.c | 2 +- > drivers/rtc/rtc-omap.c | 6 ++-- > drivers/rtc/rtc-pcap.c | 16 +++++----- > drivers/rtc/rtc-pl030.c | 24 +++++++-------- > drivers/rtc/rtc-pl031.c | 31 ++++++++----------- > drivers/rtc/rtc-pm8xxx.c | 22 +++++++------- > drivers/rtc/rtc-rs5c348.c | 4 +-- > drivers/rtc/rtc-sa1100.c | 25 +++++++--------- > drivers/rtc/rtc-sh.c | 2 +- > drivers/rtc/rtc-sirfsoc.c | 18 +++++------ > drivers/rtc/rtc-snvs.c | 14 ++++----- > drivers/rtc/rtc-stk17ta8.c | 2 +- > drivers/rtc/rtc-stmp3xxx.c | 12 ++++---- > drivers/rtc/rtc-sun6i.c | 14 ++++----- > drivers/rtc/rtc-sysfs.c | 25 ++++++++-------- > drivers/rtc/rtc-tegra.c | 22 +++++++------- > drivers/rtc/rtc-test.c | 17 +---------- > drivers/rtc/rtc-tps6586x.c | 26 ++++++++-------- > drivers/rtc/rtc-vr41xx.c | 6 ++-- > drivers/rtc/rtc-wm831x.c | 28 +++++++---------- > drivers/rtc/rtc-xgene.c | 12 ++++---- > kernel/power/suspend_test.c | 6 ++-- > 51 files changed, 342 insertions(+), 420 deletions(-) > > -- > CC: adi-buildroot-devel@lists.sourceforge.net > CC: Alessandro Zummo > CC: Alexandre Belloni > CC: Gregory Clement > CC: Ingo Molnar > CC: Jason Cooper > CC: John Stultz > CC: linux-arm-kernel@lists.infradead.org > CC: linux-kernel@vger.kernel.org > CC: Linus Walleij > CC: Michael Chan > CC: netdev@vger.kernel.org > CC: rtc-linux@googlegroups.com > CC: Sebastian Hesselbarth > CC: Support Opensource > CC: Thomas Gleixner > CC: x86@kernel.org > CC: Baruch Siach > CC: Hans Ulli Kroll > CC: Vladimir Zapolskiy > CC: Sylvain Lemieux > CC: Barry Song > CC: Maxime Ripard > CC: Chen-Yu Tsai > CC: Thierry Reding > CC: Jonathan Hunter > CC: linux-tegra@vger.kernel.org > CC: patches@opensource.wolfsonmicro.com > CC: "Rafael J. Wysocki" > CC: Pavel Machek > CC: Len Brown > CC: linux-pm@vger.kernel.org > > 1.9.1 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com