Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdFTKwg (ORCPT ); Tue, 20 Jun 2017 06:52:36 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36602 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbdFTKwe (ORCPT ); Tue, 20 Jun 2017 06:52:34 -0400 Subject: Re: [PATCH] backlight: pwm_bl: make of_device_ids const To: Arvind Yadav , thierry.reding@gmail.com, lee.jones@linaro.org, jingoohan1@gmail.com, b.zolnierkie@samsung.com Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Daniel Thompson Message-ID: <2574238d-640f-79b3-4650-c51766b4a478@linaro.org> Date: Tue, 20 Jun 2017 11:52:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 28 On 20/06/17 08:52, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Acked-by: Daniel Thompson > --- > drivers/video/backlight/pwm_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index 002f1ce..9bd1768 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev, > return 0; > } > > -static struct of_device_id pwm_backlight_of_match[] = { > +static const struct of_device_id pwm_backlight_of_match[] = { > { .compatible = "pwm-backlight" }, > { } > }; >