Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751082AbdFTL2X (ORCPT ); Tue, 20 Jun 2017 07:28:23 -0400 Received: from mail-qk0-f180.google.com ([209.85.220.180]:34230 "EHLO mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbdFTL2W (ORCPT ); Tue, 20 Jun 2017 07:28:22 -0400 MIME-Version: 1.0 In-Reply-To: <0a6ae44cf7d0fb54380809ae0e52234dbd3f367a.1497934979.git.arvind.yadav.cs@gmail.com> References: <0a6ae44cf7d0fb54380809ae0e52234dbd3f367a.1497934979.git.arvind.yadav.cs@gmail.com> From: Benjamin Gaignard Date: Tue, 20 Jun 2017 13:28:21 +0200 Message-ID: Subject: Re: [PATCH] drm: sti: sti_hqvdp: make of_device_ids const. To: Arvind Yadav Cc: Vincent Abriou , David Airlie , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1284 Lines: 37 2017-06-20 7:05 GMT+02:00 Arvind Yadav : > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 15845 640 0 16485 4065 drivers/gpu/drm/sti/sti_hqvdp.o > > File size after constify hqvdp_of_match: > text data bss dec hex filename > 16229 224 0 16453 4045 drivers/gpu/drm/sti/sti_hqvdp.o > > Signed-off-by: Arvind Yadav Applied on drm-misc-next, thanks > --- > drivers/gpu/drm/sti/sti_hqvdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c > index 267d816..075802d 100644 > --- a/drivers/gpu/drm/sti/sti_hqvdp.c > +++ b/drivers/gpu/drm/sti/sti_hqvdp.c > @@ -1396,7 +1396,7 @@ static int sti_hqvdp_remove(struct platform_device *pdev) > return 0; > } > > -static struct of_device_id hqvdp_of_match[] = { > +static const struct of_device_id hqvdp_of_match[] = { > { .compatible = "st,stih407-hqvdp", }, > { /* end node */ } > }; > -- > 1.9.1 >