Date: Tue, 20 Jun 2017 15:05:39 +0100
From: Will Deacon <will.deacon@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Stefan Traby <stefan@hello-penguin.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: remove a redundancy in sysreg.h
Message-ID: <20170620140539.GD21131@arm.com>
References: <20170620133042.mlqgpx5vddgvoe6k@hello-penguin.com>
 <6d18962d-5557-1d57-95da-2ae1c437440b@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6d18962d-5557-1d57-95da-2ae1c437440b@arm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1171
Lines: 35

On Tue, Jun 20, 2017 at 02:54:15PM +0100, Marc Zyngier wrote:
> On 20/06/17 14:30, Stefan Traby wrote:
> > This is really trivial; there is a dup
> > (1 << 16) in the code
> > 
> > Signed-off-by: Stefan Traby <stefan@hello-penguin.com>
> > ---
> >  arch/arm64/include/asm/sysreg.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
> > index 2d3e155b185f..580965129fea 100644
> > --- a/arch/arm64/include/asm/sysreg.h
> > +++ b/arch/arm64/include/asm/sysreg.h
> > @@ -139,8 +139,8 @@
> >  #define SCTLR_ELx_M	1
> >  
> >  #define SCTLR_EL2_RES1	((1 << 4)  | (1 << 5)  | (1 << 11) | (1 << 16) | \
> > -			 (1 << 16) | (1 << 18) | (1 << 22) | (1 << 23) | \
> > -			 (1 << 28) | (1 << 29))
> > +			 (1 << 18) | (1 << 22) | (1 << 23) | (1 << 28) | \
> > +			 (1 << 29))
> >  
> >  #define SCTLR_ELx_FLAGS	(SCTLR_ELx_M | SCTLR_ELx_A | SCTLR_ELx_C | \
> >  			 SCTLR_ELx_SA | SCTLR_ELx_I)
> > 
> 
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> 
> Catalin, Will: do you want to get that through arm64? Alternatively, I
> get stash it in the KVM tree.

I can pick it up.

Will