Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752628AbdFTOKK (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 10:10:10 -0400
Received: from mail.free-electrons.com ([62.4.15.54]:54374 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751025AbdFTOKI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 10:10:08 -0400
Date: Tue, 20 Jun 2017 16:09:56 +0200
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Kumar Gala <galak@codeaurora.org>, Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Gregory Clement <gregory.clement@free-electrons.com>,
        linux-arm-kernel@lists.infradead.org,
        Nadav Haklai <nadavh@marvell.com>, Hanna Hawa <hannah@marvell.com>,
        Yehuda Yitschak <yehuday@marvell.com>,
        Antoine Tenart <antoine.tenart@free-electrons.com>
Subject: Re: [PATCH v3 4/6] irqchip: irq-mvebu-icu: new driver for Marvell
 ICU
Message-ID: <20170620160956.361ed003@windsurf.lan>
In-Reply-To: <7c5d8d75-1319-a9ae-856d-67813ad2e1c5@arm.com>
References: <20170616141923.31226-1-thomas.petazzoni@free-electrons.com>
        <20170616141923.31226-5-thomas.petazzoni@free-electrons.com>
        <2934dbf3-e1f0-3997-ba70-3b6a7a2973d9@arm.com>
        <20170620154631.77a1f192@windsurf.lan>
        <7c5d8d75-1319-a9ae-856d-67813ad2e1c5@arm.com>
Organization: Free Electrons
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 736
Lines: 29

Hello,

On Tue, 20 Jun 2017 15:00:19 +0100, Marc Zyngier wrote:

> There is a few things: this driver could (mostly) work with a GICv3
> distributor (located way above 4GB) instead of the GICP, and I'd rather
> make no assumption of where GICP is located in the memory map.
> 
> So I'd rather see:
> 
> 	if (msg->address_lo || msg->address_hi) {
> 		[...]
> 	} else {
> 		/* deconfiguration case */
> 	}

Ha, OK, indeed. /me feels stupid now.

Unfortunately, I just sent v4 a few minutes ago. I'll wait for you to
look at this v4. If there's nothing else to be changed, then I'll send
a v5 with just this change.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com