Message-ID: <1497969426.3177.14.camel@nxp.com>
Subject: Re: [PATCH v5 3/6] kernel/reboot.c: export pm_power_off_prepare
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
CC: Andrew Morton <akpm@linux-foundation.org>,
        <devicetree@vger.kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>,
        <kernel@pengutronix.de>, Liam Girdwood <lgirdwood@gmail.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "Michael Turquette" <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, Russell King <linux@armlinux.org.uk>,
        Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@codeaurora.org>
Date: Tue, 20 Jun 2017 17:37:06 +0300
In-Reply-To: <5023d338-f845-b8a6-c4a0-d414c75f841c@pengutronix.de>
References: <20170619050245.2632-1-o.rempel@pengutronix.de>
         <20170619050245.2632-4-o.rempel@pengutronix.de>
         <1497872109.5380.10.camel@nxp.com>
         <5023d338-f845-b8a6-c4a0-d414c75f841c@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2017 14:37:12.5824
 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB2005
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1549
Lines: 43

On Tue, 2017-06-20 at 07:01 +0200, Oleksij Rempel wrote:
> 
> On 19.06.2017 13:35, Leonard Crestez wrote:
> > 
> > On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote:
> > > 
> > > Export pm_power_off_prepare. It is needed to implement power off on
> > > Freescale/NXP iMX6 based boards with external power management
> > > integrated circuit (PMIC).
> > > 
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > >  kernel/reboot.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/kernel/reboot.c b/kernel/reboot.c
> > > index bd30a973fe94..a6903bf772c7 100644
> > > --- a/kernel/reboot.c
> > > +++ b/kernel/reboot.c
> > > @@ -49,6 +49,7 @@ int reboot_force;
> > >   */
> > > 
> > >  void (*pm_power_off_prepare)(void);
> > > +EXPORT_SYMBOL(pm_power_off_prepare);
> > > 
> > Could you register a reboot notifier in the pfuze driver instead? Right
> > now the only user of pm_power_off_prepare is ACPI so this alternative
> > seems less intrusive.
> hm... in this case i will need to make sure that reboot handler is not 
> executed on reboot. This will make code looks strange. Which is opposite 
> of your comment in other email about strange standby code for power off :)
> Should i really do this?

A reboot handler receives a parameter to differentiate between reboot
and shutdown so it would be easy. Isn't it preferable to use an
existing mechanism instead of exporting a new symbol?

But maybe somebody else will Ack this, I don't particularly insist on
changing this.

--
Regards,
Leonard