Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbdFTOpy (ORCPT ); Tue, 20 Jun 2017 10:45:54 -0400 Received: from scorn.kernelslacker.org ([45.56.101.199]:58646 "EHLO scorn.kernelslacker.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbdFTOpx (ORCPT ); Tue, 20 Jun 2017 10:45:53 -0400 Date: Tue, 20 Jun 2017 10:44:07 -0400 From: Dave Jones To: Hugh Dickins Cc: Linus Torvalds , Linux Kernel Mailing List , Oleg Nesterov , Michal Hocko Subject: Re: Linux 4.12-rc6 Message-ID: <20170620144407.2wbyxrzmkwsz4mxe@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Hugh Dickins , Linus Torvalds , Linux Kernel Mailing List , Oleg Nesterov , Michal Hocko References: <20170620002612.bwjphlk2qz3ynghl@codemonkey.org.uk> <20170620034222.nykxdbagaqa3rqni@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170306 (1.8.0) X-Spam-Note: SpamAssassin invocation failed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 31 On Tue, Jun 20, 2017 at 02:05:53AM -0700, Hugh Dickins wrote: > On Mon, 19 Jun 2017, Dave Jones wrote: > > > > I hacked up this harness to try and narrow it down more.. > > > > #!/bin/bash > > > > . scripts/taint.sh > > > > while [ 1 ]; > > do > > ./trinity -a64 -C1 -c mmap -N1 --enable-fds=testfile > > check_tainted > > done > > Very helpful reproducer, thank you Dave: I tried a couple of times, > and it crashed in about 3 minutes each time. And good news is that > the check that Linus suggested does indeed fix it. I'm anxious to > send the patch in now, so have only tested about half an hour on > x86_64 and half an hour x86_32 so far, just to make sure that at > least there isn't something too embarrassing just around this first > corner (some of the time with ulimit -s at default 8192, some of > the time unlimited, since that affects layout decisions). I'll > send in the patch now - many thanks for catching this so quickly. Confirming that the patch seems to be doing the job for me too. I'll leave it run for the morning, but initial results look good. thanks, Dave