Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751736AbdFTPhF (ORCPT ); Tue, 20 Jun 2017 11:37:05 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:58371 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdFTPhE (ORCPT ); Tue, 20 Jun 2017 11:37:04 -0400 Date: Tue, 20 Jun 2017 17:36:51 +0200 From: Thomas Petazzoni To: Gregory CLEMENT Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Nadav Haklai , Hanna Hawa , Yehuda Yitschak , Antoine Tenart , =?UTF-8?B?TWlxdcOobA==?= Raynal Subject: Re: [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K Message-ID: <20170620173651.6370ea58@windsurf.lan> In-Reply-To: <87tw3a3dy4.fsf@free-electrons.com> References: <20170620140722.31646-1-thomas.petazzoni@free-electrons.com> <20170620140722.31646-7-thomas.petazzoni@free-electrons.com> <87tw3a3dy4.fsf@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.15.0git70 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 29 Hello, On Tue, 20 Jun 2017 16:56:35 +0200, Gregory CLEMENT wrote: > > +#include > > With this line you created a dependency with the patch "irqchip: > irq-mvebu-icu: new driver for Marvell ICU". And without it the dtb is > not buidable. > > So either I wait for the next kernel release to apply it or I will need > a stable branch with the commit adding the mvebu-icu.h file. Alternatively, I could change the patch to use hardcoded values for now (i.e replace ICU_GRP_NSR everywhere by 0x0), and then change it during the next kernel cycle to use the #define value. I would really prefer such a solution to a solution where merging the entire ICU DT change would be delayed by one cycle. Let me know what you prefer. Maybe Marc can say if the irqchip maintainers can provide a stable branch containing the mvebu-icu.h file. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com