Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbdFTQ4F (ORCPT ); Tue, 20 Jun 2017 12:56:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:44594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbdFTQ4D (ORCPT ); Tue, 20 Jun 2017 12:56:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BB5E2397B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Tue, 20 Jun 2017 17:55:52 +0100 From: Jonathan Cameron To: Eugen Hristev Cc: , , , , , , , , Subject: Re: [PATCH v5 1/4] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin Message-ID: <20170620175552.2ec49c56@kernel.org> In-Reply-To: <1497533097-12052-2-git-send-email-eugen.hristev@microchip.com> References: <1497533097-12052-1-git-send-email-eugen.hristev@microchip.com> <1497533097-12052-2-git-send-email-eugen.hristev@microchip.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1667 Lines: 48 On Thu, 15 Jun 2017 16:24:54 +0300 Eugen Hristev wrote: > Enable pinctrl for ADTRG pin (PD31) for ADC hardware trigger support. > > Signed-off-by: Eugen Hristev > Acked-by: Ludovic Desroches The driver changes are on their way upstream. Acked-by: Jonathan Cameron > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > index 0bef9e0..04754b1 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > @@ -303,7 +303,7 @@ > vddana-supply = <&vdd_3v3_lp_reg>; > vref-supply = <&vdd_3v3_lp_reg>; > pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_adc_default>; > + pinctrl-0 = <&pinctrl_adc_default &pinctrl_adtrg_default>; > status = "okay"; > }; > > @@ -322,6 +322,20 @@ > bias-disable; > }; > > + /* > + * The ADTRG pin can work on any edge type. > + * In here it's being pulled up, so need to > + * connect it to ground to get an edge e.g. > + * Trigger can be configured on falling, rise > + * or any edge, and the pull-up can be changed > + * to pull-down or left floating according to > + * needs. > + */ > + pinctrl_adtrg_default: adtrg_default { > + pinmux = ; > + bias-pull-up; > + }; > + > pinctrl_charger_chglev: charger_chglev { > pinmux = ; > bias-disable;