Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbdFTRpZ (ORCPT ); Tue, 20 Jun 2017 13:45:25 -0400 Received: from mail-yw0-f174.google.com ([209.85.161.174]:33912 "EHLO mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbdFTRpY (ORCPT ); Tue, 20 Jun 2017 13:45:24 -0400 Date: Tue, 20 Jun 2017 13:45:21 -0400 From: Tejun Heo To: Dennis Zhou Cc: Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/4] percpu: add basic stats and tracepoints to percpu allocator Message-ID: <20170620174521.GD21326@htj.duckdns.org> References: <20170619232832.27116-1-dennisz@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170619232832.27116-1-dennisz@fb.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 29 On Mon, Jun 19, 2017 at 07:28:28PM -0400, Dennis Zhou wrote: > There is limited visibility into the percpu memory allocator making it hard to > understand usage patterns. Without these concrete numbers, we are left to > conjecture about the correctness of percpu memory patterns and usage. > Additionally, there is no mechanism to review the correctness/efficiency of the > current implementation. > > This patchset address the following: > - Adds basic statistics to reason about the number of allocations over the > lifetime, allocation sizes, and fragmentation. > - Adds tracepoints to enable better debug capabilities as well as the ability > to review allocation requests and corresponding decisions. > > This patchiest contains the following four patches: > 0001-percpu-add-missing-lockdep_assert_held-to-func-pcpu_.patch > 0002-percpu-migrate-percpu-data-structures-to-internal-he.patch > 0003-percpu-expose-statistics-about-percpu-memory-via-deb.patch > 0004-percpu-add-tracepoint-support-for-percpu-memory.patch Applied to percpu/for-4.13. I had to update 0002 because of the recent __ro_after_init changes. Can you please see whether I made any mistakes while updating it? git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git for-4.13 Thanks. -- tejun