Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbdFTTVp (ORCPT ); Tue, 20 Jun 2017 15:21:45 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42144 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbdFTTVo (ORCPT ); Tue, 20 Jun 2017 15:21:44 -0400 Date: Tue, 20 Jun 2017 15:21:42 -0400 (EDT) Message-Id: <20170620.152142.1443468587541525646.davem@davemloft.net> To: dvlasenk@redhat.com Cc: netdev@vger.kernel.org, felix.manlunas@cavium.com, prasad.kanneganti@cavium.com, derek.chickles@cavium.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data From: David Miller In-Reply-To: <20170619195052.13176-1-dvlasenk@redhat.com> References: <20170619195052.13176-1-dvlasenk@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Jun 2017 11:40:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 447 Lines: 13 From: Denys Vlasenko Date: Mon, 19 Jun 2017 21:50:52 +0200 > Only compile-tested - I don't have the hardware. > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > anyway. > > Signed-off-by: Denys Vlasenko Looks good to me but I'll let one of the liquidio guys review this first before I apply it.