Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752283AbdFTTWr (ORCPT ); Tue, 20 Jun 2017 15:22:47 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42170 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbdFTTWp (ORCPT ); Tue, 20 Jun 2017 15:22:45 -0400 Date: Tue, 20 Jun 2017 15:22:44 -0400 (EDT) Message-Id: <20170620.152244.1055779320531168153.davem@davemloft.net> To: julien@arista.com Cc: nikolay@cumulusnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sharpd@cumulusnetworks.com, nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next v2 0/4] ipmr/ip6mr: add Netlink notifications on cache reports From: David Miller In-Reply-To: <20170619204417.13230-1-julien@arista.com> References: <20170619204417.13230-1-julien@arista.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Jun 2017 11:41:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 26 From: Julien Gomes Date: Mon, 19 Jun 2017 13:44:13 -0700 > Currently, all ipmr/ip6mr cache reports are sent through the > mroute/mroute6 socket only. > This forces the use of a single socket for mroute programming, cache > reports and, regarding ipmr, IGMP messages without Router Alert option > reception. > > The present patches are aiming to send Netlink notifications in addition > to the existing igmpmsg/mrt6msg to give user programs a way to handle > cache reports in parallel with multiple sockets other than the > mroute/mroute6 socket. > > Changes in v2: > - Changed attributes naming from {IPMRA,IP6MRA}_CACHEREPORTA_* to > {IPMRA,IP6MRA}_CREPORT_* > - Improved packet data copy to handle non-linear packets in > ipmr/ip6mr cache report Netlink notification creation > - Added two rtnetlink groups with restricted-binding > - Changed cache report notified groups from RTNL_{IPV4,IPV6}_MROUTE to > the new restricted groups in ipmr/ip6mr Please address Nikolay's feedback about interface number limits etc. Thanks.