Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbdFTUvf (ORCPT ); Tue, 20 Jun 2017 16:51:35 -0400 Received: from mail-cys01nam02on0054.outbound.protection.outlook.com ([104.47.37.54]:26873 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751131AbdFTUvd (ORCPT ); Tue, 20 Jun 2017 16:51:33 -0400 Authentication-Results: cavium.com; dkim=none (message not signed) header.d=none;cavium.com; dmarc=none action=none header.from=cavium.com; Date: Tue, 20 Jun 2017 13:51:25 -0700 From: Felix Manlunas To: Derek Chickles Cc: David Miller , "dvlasenk@redhat.com" , "netdev@vger.kernel.org" , "Kanneganti, Prasad" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data Message-ID: <20170620205125.GA1364@felix-thinkpad.cavium.com> References: <20170619195052.13176-1-dvlasenk@redhat.com> <20170620.152142.1443468587541525646.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [169.139.19.222] X-ClientProxiedBy: DM5PR04CA0065.namprd04.prod.outlook.com (10.172.183.155) To MWHPR07MB3181.namprd07.prod.outlook.com (10.172.96.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 06117fcd-2bdf-4d82-cf50-08d4b81e2120 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:MWHPR07MB3181; X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;3:O4yR+mVRmZaYydIP7hwqLz/vRO6JUsT0z5uL6/TL5BxZgiLjfTUMIpmv9ceT52L1NCW3TWPSl3ES87lcnfbRjinT+mYRMDOZr+7ZQ/RTR9DI8uxfHvNUJQpICC3mCd/ujSCQmid6M2+gDLkoT391j4YlCgLI7GJV8/VSAWk4jKwJ1XrXY5Hc7khX+19tK5UGjFWaPQCQuWX7xIi1jADnQ5RabILytv89iqaiTgyeoBHEYsznmqkE16IQwikWLuwDgwGdr9UZq9jpoPaCvg1y1Hnj2Klq7atvbSRW/sWGd1v2vly+czvObsfvNw+JYjuuukpyz6g9xqunu5yand6GAw== X-MS-TrafficTypeDiagnostic: MWHPR07MB3181: X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;25:sxsxiIs0GbevuAYhAqlLXdx9B4kmAEBmXEJbVyl4ZmLtrCp3d1RC+gzRSW2kai13FRCeRmNiflfAjvZ0YIDm7LcaMpEHthHazHLvtmcN55wBPC/T4MMi4ich/NZhlbWmJsaCSRYT/f+lob+YrQCVghijdjl81hEo7z8S5uAa+YtM6DRFOQ7rOm9ddUeeespxCIdgf9PAocKcB1F/FIUn9O1vk0MwicC1rtccX8NbX/90T02453f7NDqcoUH2tQfbIwQQzaasRhr8BsSOGb+LgYItOLN8DCbYnF8pZLqxW3SD79mUVTf2QYWMtnx8DxJS0ibhYpIWcn4/zn0Lz7Wzh86kxFF0TBRy0iSNBNIEelLjlQEQ+M4MxSz3XDbx2Fod8E8Cf7pIIo+YOYlQYxxyfxFHBaDYu0OpnOccrJBxfKkgfYxTpI+NcuLiBomGPRrQIO9QrXgT4VPCoPI4UmYt61mi56isJE/fKTs/BArHwbWW2utoz/o8ORNbblEP+oa5Diyt7f3523uyMiBhdxyysuV0K8nLekn+Z/91kVDrz/lBv25wl2xPcfULJwKP6Q0DcF57cJANER4islLma4tHBWsOsboz379wLqP0dkyW4JQrvgtbkxtFu+1O6SR0qaBQ69r5l+wWWW2rlVIofEb9e5hs0VcnEHywGhXIVNong5y9okk40dwMm78IqKxP/2ywPuaTEPaNb49zTAcY0CK+T3CEj1w3bnmEa4U8WKmcFT+xW1H+McNiqPCuvA0BLwYPKQ/d5K2k77D3QY94np4YxaJJ/gWdtUfkVgTzo56Tx2c3UiO9pQvoxBylf33qFxgR7yI29JhbC6w1HGrGsMmbIMefgoDAOgSAoYM1BjoIxvFtLQuQ4O8vhJ2yIO9XyoG3gGPMc1db2wIZnvpsdR3RZPTrLSVPPOqtZzgpQytvkTk= X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;31:0yDG1p5q6hqUANwCen2mK8Tb/Xae1IzTgGY9esEkQmj2MprYqqxyiDHvZNbTzAYLb2+fcpB2pCMqSvp7mgZfOV2weN+jMt2OmGnCjLJMcZLdW8AtRG74BQIS7u3jezcIPbl8Hp+61+E0JKaeK1QpkGr8LBlwMOZERAVbrzUuBZtestgY3TrY9j+Je/d+ejsN+tGAO7ymnBy2lkQ7HfaoA1qC6Uax8hq8VGmXnK1ONzal4IIQJ2vqqzMVw/QwwBs4eEADtLvPQphbS1OIJnv9x5J9GpACFa/Khx3Ymf7b/xDqevE9pDuQFLezbysZsQUHujmFkyRv3OKFmOTO1RaqO6WmFpVcV4LnFumBAqWt6N2hf3ZTx+Oo3Fq+WlbHfKi1H94Axrt4Hfk7umvOSvjB9xT3q31fiB6Bjjqw72gx9zRKY7/v089x980uAWdGIrZpovJqcG1jgAJIrCv3D7VLz/g6efmQCKsSjd6lIr9OTKgj3N4JB0ylfFTPNi27Fd1jOiWtxFOE0YXJ0nUb3sqhHOmySTiPrP5RjCcnWxG6sdF83LHoKn+++6LKe4XK9mPNEP2psW2rLnSi6FhdjD3JPCA7RUwJcBwgHxgmuUjqSX5Hi0V14vUrNmA/oX6yh1N/QDUsv+cy7I4ozLfC/yGRgHpaaeRAOG7ZWeQeKz1KnsA= X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;20:KcR1g6SlaerXEnQNcjzHUK1MU7qz4f4rDfNUY+l2whxuz5EA+VBUzLF7kishqFy87MkXaezLkSHz7a2YfAfuNRm0/DQzBg5LjCPDZHtkEUdlfBZXyyPWBP58RE3H1WwoXWS5x5bDxjFzqnapBMkqiDO7XssCNxCmuwkufqlSjkM8OgcUVjtD5MafZb1BNpa/6ypevmYNO1JhK5qTMJfOl77/WVflp0JNo+URnQ0K0yPUSJVKErDbwSBohufXDq/yoDTxvX9bXoN2d39bdA1yCGceFIYmZzndQHcl7iL3keSqrQRQFaQAvktlVvgbPEaJpk3ToyVGMb/AZCMr9aIs45nZfVSumYuZGGJfpMhnlKRlc1z18iNDgoQPAUyqa/1aOGbSqleeSxxGkemhlCJQnJKzUvWiW1Kq2FJigte9O8kl1zaqMqub1gN0SDYeLEz1t+likvx76AYsuz0+UAk2ECBSLPCRBQNg3Ad/vdFCCoprWq2ko73hLMpL5VfSONLl X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123560025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3181;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3181; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR07MB3181;4:lYS7TpJVdgaOYIV/kdfNxteLk99H5e0+DAujDUjkYs?= =?us-ascii?Q?rdUPyT30dXs33o8YI6wzflED24l5eQgeAAhmprAAx6RTz31xleNWm8kTKvKe?= =?us-ascii?Q?tvDTiu+mqpA929CbJ438pEZU+pJhV6w5DL69ifHdz/P0h9IVyQoaWG6Wr3jt?= =?us-ascii?Q?QwjQLPT+aInFJcF4VQyZiIgotab45wkYXpVgmFtCsqPxOuUwZR5jwd+ZZPvq?= =?us-ascii?Q?uD1T/+6DTB0Wnhyfs3JjjbMnhwDrfJeExW1Pjhiq74extPIiEiUw5fNZeTFr?= =?us-ascii?Q?NjIo+Rt1jwuyjrxFOyvLIe8XVLZKohWgBWKpueiBtPwgzdeJXcsC95ohkOGP?= =?us-ascii?Q?JMZP3HMxkw6wy1FFXUBmyUX+bevMHTE/LLj0Dp2WB8k/ZFeWtX+0I216lTyn?= =?us-ascii?Q?XIG8aWrMXm9wYNAjPMeut+zUrlrrNSntXOBp3GL1QQJmYKc5SlDwJ9Fjjl/2?= =?us-ascii?Q?jQtWQXUiEqnAUMuWYuyI1WM2WL70z3FZEUQDX6UsUqQlu1CW3ZQrYiLcP1M9?= =?us-ascii?Q?P+TYzJsNJ7eLpzo6ERWyT2Cz7UCK9jr3X7OfC4pmGHM7CaEtYTU0yK6CCvOs?= =?us-ascii?Q?L0Q9gM6H8jvPUBBMFB4Gs6jY7MtY7wgKkqmufYe2rNQlzPLde0gKcjT6zv98?= =?us-ascii?Q?8kp+OdAdn3zTNzrg/OvqS4tOSFt/Gb0qHjffOhX43+30koCJF2hYeogZDK9q?= =?us-ascii?Q?9YMhnn3WW1YwFl3g4I3QdrFCN98AiGsLd0BxbJPZuaYoLpV0boKnD5vP8zZ1?= =?us-ascii?Q?ZSB/7oQjZU78EDicdgLShmVfYdKyT0tk/6ExuhGIr5yFpe87eG5xXzqwbge4?= =?us-ascii?Q?onhufuCx9rDKUfHooMB5tWJo5rfUUnOOw4spir2aGXX5v2maDn7ad3FI+MGI?= =?us-ascii?Q?IAEa+0YqmaIOVMyJpeQT10kTLgy2Xjhy8uDgw0dfR6TQZSdW0a25hpVspyLt?= =?us-ascii?Q?BBLPJYFGJfyrgP7BRwT+e5FlrD/OcQg9FFwl/pC3ZhGbET+7jzMqiat8vjo2?= =?us-ascii?Q?0d7oBJJKLtBD9xn8ICFEcbbCbXIQMarh+NutFosmZwR2sv2y5MIC8hGcmrn6?= =?us-ascii?Q?EVRqa5A791Yqn1keWY6CYmcXc7aTzj4NXdgx3kJ/2Nj5oSBGr7A02jhnNjnA?= =?us-ascii?Q?UesE3VGBoCEPmdGZK7h/eTqK0IcTvs?= X-Forefront-PRVS: 03449D5DD1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(39450400003)(39840400002)(39410400002)(39400400002)(39850400002)(377454003)(6636002)(4326008)(229853002)(5660300001)(2950100002)(6666003)(76176999)(23726003)(50986999)(189998001)(54356999)(1076002)(305945005)(25786009)(6116002)(3846002)(33656002)(2906002)(42186005)(4001350100001)(50466002)(66066001)(53936002)(47776003)(7736002)(76506005)(83506001)(54906002)(72206003)(478600001)(6486002)(110136004)(8676002)(81166006)(38730400002)(86362001)(6496005)(18370500001)(142923001)(14583001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3181;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR07MB3181;23:RBPf1kB/+mBob92zvk2j1m0rb/f3p8SJWB+almEW9?= =?us-ascii?Q?vWLqvZYollbL+GG1tjGuNnxZ24wm33c65TIU8ASvp33I3ZLeBZZMuI/hi2nv?= =?us-ascii?Q?H1tkN2rNLBJdj0fKV1fTkN7iYrXfZurUkyS9q+V6mwowX9V+oThArWFtsaWn?= =?us-ascii?Q?qxI1ry0R2jQpbtXohZDsnXbPVJ7YtOKrNQX4NJnJ41SVzy9nyfklCKhua+vE?= =?us-ascii?Q?G75f23VQZXwC2K7pRHXQ4bfdA28yaL+srJ1geuIkk8uSC7uBK3nBI7ET5/Me?= =?us-ascii?Q?xoNIkZcAhnTktNZK2EtcppElDdSDwJXilWZNCYjZ51i0H7HQRjqtZJPnkiop?= =?us-ascii?Q?jtlIii95/HH0WNftKKeeyelLng+X94HH1tcisBFdS7Vj19psv+AIaw3JPJ42?= =?us-ascii?Q?jyz1sN+dfYRMci3KJnLPaT6GMCvi9NbFpYW0IqTmrMh7fU+kGZ0yF8/7uc+r?= =?us-ascii?Q?BVmfwCK0gA4bzinmy6WnIy7GPKF6yYCO530D+kzhRRzlrAJSBAG2mDzQw8ux?= =?us-ascii?Q?Aa3YcF3jOEMcEy5a9CuopsTtUBt5wUGbKoU6SdmIFBoBWwXa3+yYg5alzNfe?= =?us-ascii?Q?etvHsyVyrk6GylWp+mvXMxiyvyQe50YTDZnrMGPEe4WdXQDd1FvC47Me9dri?= =?us-ascii?Q?DDRCt55CCB9LHBfn5qJKxRpd3bzBvRmz+Xt5zqyjlltUCiMS/C9MiCYOtUnA?= =?us-ascii?Q?dXgi83kvBSmNoGGTwDxmBv53kyseUHPW7n9FBmYnNbVqIZq5dVnxBHCF5JCu?= =?us-ascii?Q?po347rEyYgTd/9kR0sW3W7XC4PYGDg3UsD6gmy/jDwjoV+KacCb1yfUiegNq?= =?us-ascii?Q?zq4NCy37FmwVK+xSKJrLJUgTw32mT3Jtx8SSLxlMTC0jo3PuaLw8gslJDQyK?= =?us-ascii?Q?FAU794TvYSv4Rqy+vBpqksuYK9vy/w3P/hn3o/sBJfN6prYkCMj5mlHJrsWh?= =?us-ascii?Q?YzDtamJ5+eGrMMiMwKSoOhGWPXL5CJimzMuSxbg/1z5MCIYAHgGVD+XGuvP5?= =?us-ascii?Q?2WGZjtuGqNdp77oHb1zPuh7+1gDJjrEMR4uNu9zqfq+NWENz3GoC0H5SYGaN?= =?us-ascii?Q?cPvtcfOwpL746JZ+CgP6VXNZHcXbEg5FQnW3LdIJLM5vGFrAqVbot+hlnjv4?= =?us-ascii?Q?UcEFeWD5jym57dWg1G2gBcx0iKwi9XEq5hDN5j+cospm37l3Bty9kFKkwnI1?= =?us-ascii?Q?UgXi4UHadH1U4Du8GXHx70o7iU0zmt/PgGkgBFkGnFYVF7ui2/uL0vHkw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR07MB3181;6:b1wBAtec09uoxdpmuag7wM9rKBLMcoeOUCA305fnWO?= =?us-ascii?Q?+5oxwNz8zZSV7R/kcgAS26SKvinuLC1FonBYsKtZZCu9Vteh8XbRB/ZcmRJm?= =?us-ascii?Q?oWF/u74DtUOeZhDskUDwiCeGca264jXBHSeIHhdzVhvWowBxG1SB9fQpn+qU?= =?us-ascii?Q?Lg8lHr2HZ8YTYsqQiFBfGOctazB5x8UgLjm0Nlf3/BlYz6BK+1T/pD2NaLTC?= =?us-ascii?Q?YWOvGgjagHcXqXGZcnfOeBXmO6Eqaab273zCFh+rwiCbCYOf4mojKawgMKS0?= =?us-ascii?Q?UzHxnIJPpA63vp79R8ghB9m4ysG8CnPOxGuUJfgCgl8Q+oaKPob5MTcZjq+l?= =?us-ascii?Q?+VjgXFgb25NuQdWsKCAOmQdTQdxThd3l3ATlHULU4voREf7p6JGxMTBrWpJR?= =?us-ascii?Q?yBYvBJ6iq7CAvsHJl9lkkccY9Z8bDFagQh6ZEKfTMWHdGHKqoXKMS3+qWKbB?= =?us-ascii?Q?5wF0RStgTsWzV70I04uH4vkVVp4CAKEvNEY37Psa44hm4RQhzzdSdUq9RIHW?= =?us-ascii?Q?eI3zvKGFXFpSH9LDxsJT9nWjAisCZJU7JgBmv0MRc+9OwenLDbS/vPRQkwDn?= =?us-ascii?Q?o7Purs+eM678CSGtlT7Gnu/D5EYxUnDznmnfIydojPl/2pHVWg9rHQMtDo9b?= =?us-ascii?Q?+l5L5Gp3BbNs9PE5xO5pLvllMaDuGSXpyps+kqKW27eD53Lz/ESZTQFjSm3S?= =?us-ascii?Q?6A0+HOQA7TAj86ZV6TfFTQJjqGkFcaI4zPfUj5GxFCTeipbhCwtVxe3rjtic?= =?us-ascii?Q?3z5ZAyQLXSUY11X+rXxZkAz4g84/Shv/ULxo+EegyxQugDZsxC5g2009l4ur?= =?us-ascii?Q?d14ibcRp462MNHesaVUSPgUTSijAux0pFTFk48V1IV8h3LgJmJinmU2Ww2Gu?= =?us-ascii?Q?BnvLTLYo84lgYEaxrplb5HM5/YbKgbmy/3uOa1vcxWxKEUlQKNxn3PYt2aZ0?= =?us-ascii?Q?3wkOz0aulvhn+NHRtfObjvdxDbp3/N6W2a92/TM6IJbEx52XU0nOoUDZrQri?= =?us-ascii?Q?o=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;5:YuZcAZknU8OQuVXWRyvQHKnfxOHb5WMTYETgqMu/jZH8aeqXXgYJxx3tVrA/0bKA9r7EYdz0agdAy6yIvUraouUMSuo5I1ZTmM6KrOLsiOB1mqLluyFxLynrfld+V4MD5+faMpkxKnyys46v8KzTIquwmsOvOw+v4zOu7wpcbaAOOHrANX6prdIdtDS2poUp+zEvbNhuFc0zpqwKmxiEsy2IiS4MmUDCNVDCgc96EyieINVlOYBS+cu9evXTiOBvTn+kSlxSwjR23t7fKCOK9+ouPOMLM4LR1oQALbLzlAHXoaQAo9kzav1ln9V1uOVCIFsxuMcTKE+grrcm66vQ4D4e6G2jQbD4JA/4XYqtuVq7NHwTcE6KDTZY7LtKxzy1i5f7BDh2/mCdKMV9xaBVc+eyNUtzJuyhEA58IRW95TY7+rg8teHN4IJ2J8kLYFeYc8+Vy0T1Zsx+U62TwjSPHj9+utp6q6y6kvTO443qn2nl9sBsxuxukZoEYWQfyHHV;24:6vJ25QF13voNAn7eVYs2VEXPHGKa3hjUQeZn/UtIHl48HB94SQN3ndw9Dboiw6gGVjhMdYEqDOKryTdxBt81lJPs7THrMzl3AtP8lBhNP7A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3181;7:n5psFeDP2nGIeEAn5ADvDruizDgn1FetngYLLJGV4aMiEwOjqpGxtWuAJpLPhi15kxb6J4yuliXKOKVCnNw4qzmZ4cXkHUEUShWtpPKngbK+2Ja/mNvSDWKmVbrQ3xVe35tOTjGsfRjOd2/7LxBCe/cZSTCL/BQtlhpjTCXb2tRfXTNb5b/WU2SI94ECRnkUPqi4X1p27oFc6PCHYE3PeaL1ZXDkynYHI99EDOKny1c+biLB6N++axbu+uXAroiK/zppRVAoUxjfG/+YvVYiFgVyZ2cV/HyDVo9xzlLtrKLyHLU7VGdCkQSPPlW8kHuIVy4qP8uDGM3Z+6TrfGvc9Yqdtj7hDp5kv548dZqCLH6S7fcMBi/tMnE1DvL5NMMwMPM/S8wCt7SRmEtGkUaj1wz5LWNFLrDRZ5xCpvGfXh8cCQ+Krma5eQUv3ehx1cX5UoSSvjr4zjUZGz8LCGEeMknIRXHeaKQQnIEBPyMjDsQ1ydqqTpvmDmOiFPzr9F+LmrvNdzC3p4+hKNZdMWYESmbaC57NlKkqgR5RGWyMJECXm1XGVj4g2JapWWHJvUnMs0peDJIAfGpcvgp2HILe+r3Rg+32x3IiabMh0nxGnM174yoQo4hcad530Vh9iPmDKZrvfm3fI5SuLmDWVy3ZyCmoqzN6kqi/xYquTYYXjbzdceL0KYmyIDQT3Ibrmva4xBxdc4SWnUD2bDIWI9hr+uZ4j7VjfnTClevVyywduyshfU2bbRFe4xBMtquZhbgsBKj/eupULz6q5aw+3tO7H9aIlwAZ5TKKkQX8TeVJLZ8= X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2017 20:51:30.5254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3181 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 25 From: Derek Chickles Date: Tue, 20 Jun 2017 13:15:34 -0700 > > From: David Miller [mailto:davem@davemloft.net] > > Sent: Tuesday, June 20, 2017 12:22 PM > > > > From: Denys Vlasenko > > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > > > Only compile-tested - I don't have the hardware. > > > > > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > > > anyway. > > > > > > Signed-off-by: Denys Vlasenko > > > > Looks good to me but I'll let one of the liquidio guys review this first > > before I apply it. > > Felix is going to try this out this week to confirm. Let's wait for his ack. This patch works. I tested it with a LiquidIO II adapter. ACK