Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787AbdFTVqF (ORCPT ); Tue, 20 Jun 2017 17:46:05 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:38784 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752549AbdFTVqD (ORCPT ); Tue, 20 Jun 2017 17:46:03 -0400 Date: Tue, 20 Jun 2017 14:45:56 -0700 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Andy Shevchenko , "Lee, Chun-Yi" , Platform Driver , "linux-kernel@vger.kernel.org" , "Lee, Chun-Yi" , Andy Shevchenko Subject: Re: [PATCH] acer-wmi: Using zero as the first WMI instance number Message-ID: <20170620214556.GA25900@fury> References: <20170620090623.18364-1-jlee@suse.com> <20170620164851.GA32699@pali> <201706202246.12941@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201706202246.12941@pali> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 39 On Tue, Jun 20, 2017 at 10:46:12PM +0200, Pali Roh?r wrote: > On Tuesday 20 June 2017 19:22:46 Andy Shevchenko wrote: > > On Tue, Jun 20, 2017 at 7:48 PM, Pali Roh?r > > wrote: > > > On Tuesday 20 June 2017 17:06:23 Lee, Chun-Yi wrote: > > >> Pali Roh?r found that there have some wmi query/evaluation > > >> code that they used 'one' as the first WMI instance number. > > >> But the number is indexed from zero that it's must less than > > >> the instance_count in _WDG. > > >> > > >> This patch changes those instance number from one to zero. > > >> > > >> Cc: Darren Hart > > >> Cc: Andy Shevchenko > > >> Cc: Pali Roh?r > > >> Signed-off-by: "Lee, Chun-Yi" > > > > > > Looks good, Reviewed-by: Pali Roh?r > > > > Unfortunately patchwork ignores this tag. > > So, in the future please: > > - put a tag on a separate line > > - do _not_ prepend it by any characters including white spaces > > (except new line :-) ) > > I have not known that those lines are parsed automatically. > Will do it in future! :-) Thanks! For reference, Patchwork tally's such things in the patch list view: https://patchwork.kernel.org/project/platform-driver-x86/list/ And, selfishly, the more normalized these are, the less likely Andy and I are to make mistakes manipulating them into the patches. -- Darren Hart VMware Open Source Technology Center