Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbdFTV60 (ORCPT ); Tue, 20 Jun 2017 17:58:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43354 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbdFTV6Z (ORCPT ); Tue, 20 Jun 2017 17:58:25 -0400 Date: Tue, 20 Jun 2017 14:58:14 -0700 From: Andrew Morton To: Tejun Heo Cc: Christoph Lameter , Pekka Enberg , LKML , Linus Torvalds , Vladimir Davydov , David Rientjes , Joonsoo Kim , Steven Rostedt Subject: Re: [PATCH] slub: make sysfs file removal asynchronous Message-Id: <20170620145814.9eb1b74feaf908c39e9c0de2@linux-foundation.org> In-Reply-To: <20170620204512.GI21326@htj.duckdns.org> References: <20170616085507.3cc7d4b8@gandalf.local.home> <20170619203538.GN12062@htj.duckdns.org> <20170619172750.6890df32@gandalf.local.home> <20170620204512.GI21326@htj.duckdns.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 16 On Tue, 20 Jun 2017 16:45:12 -0400 Tejun Heo wrote: > bf5eb3de3847 ("slub: separate out sysfs_slab_release() from > sysfs_slab_remove()") made slub sysfs file removals synchronous to > kmem_cache shutdown. Unfortunately, this created a possible ABBA > deadlock between slab_mutex and sysfs draining mechanism triggering > the following lockdep warning. > > ... > > Signed-off-by: Tejun Heo > Reported-by: Steven Rostedt (VMware) > Tested-by: Steven Rostedt (VMware) > Fixes: bf5eb3de3847 ("slub: separate out sysfs_slab_release() from sysfs_slab_remove()") Do you think we should add cc:stable [4.11+]?