Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbdFTWDc (ORCPT ); Tue, 20 Jun 2017 18:03:32 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35594 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdFTWDa (ORCPT ); Tue, 20 Jun 2017 18:03:30 -0400 From: frowand.list@gmail.com To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v6 0/4] of: remove *phandle properties from expanded device tree Date: Tue, 20 Jun 2017 15:02:48 -0700 Message-Id: <1497996172-821-1-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2601 Lines: 69 From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field and will still be displayed as if it is a property in /proc/device_tree. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void *. As a result of the type change, the overlay code had compile errors where the resolver updates phandle values. [1] http://lkml.iu.edu/hypermail/linux/kernel/1702.1/04160.html Patch 1 is the phandle related changes. Patches 2 - 4 are minor fixups for issues that became visible while implementing patch 1. Changes from v5: - patch 1: populate_properties(), prop_is_phandle was declared at the wrong scope and thus was initialized before the for loop instead of each time through the loop. This resulted in any property in a node after the phandle property not being unflattened. Changes from v4: - rebase on 4.12-rc1 - Add reason for "" in of_attach_node() - Simplify and consolidate phandle detection logic in populate_properties(). This results in a change of behaviour, the value of property "ibm,phandle" will no longer override the value of properties "phandle" and "linux,phandle". Changes from v3: - patch 1: fix incorrect variable name in __of_add_phandle_sysfs(). Problem was reported by the kbuild test robot Changes from v2: - patch 1: Remove check in __of_add_phandle_sysfs() that would not add a sysfs entry if IS_ENABLED(CONFIG_PPC_PSERIES) Changes from v1: - Remove phandle properties in of_attach_node(), before attaching the node to the live tree. - Add the phandle sysfs entry for the node in of_attach_node(). - When creating an overlay changeset, duplicate the node phandle in __of_node_dup(). *** BLURB HERE *** Frank Rowand (4): of: remove *phandle properties from expanded device tree of: make __of_attach_node() static of: be consistent in form of file mode of: detect invalid phandle in overlay drivers/of/base.c | 50 +++++++++++++++++++++++++++++++++++++++---- drivers/of/dynamic.c | 57 +++++++++++++++++++++++++++++++++++++------------ drivers/of/fdt.c | 43 ++++++++++++++++++------------------- drivers/of/of_private.h | 2 +- drivers/of/overlay.c | 8 ++++--- drivers/of/resolver.c | 23 +------------------- include/linux/of.h | 1 + 7 files changed, 118 insertions(+), 66 deletions(-) -- Frank Rowand