Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752945AbdFUAXU (ORCPT ); Tue, 20 Jun 2017 20:23:20 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:37751 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752915AbdFUAXS (ORCPT ); Tue, 20 Jun 2017 20:23:18 -0400 MIME-Version: 1.0 In-Reply-To: <20170620205622.GX21846@wotan.suse.de> References: <20170526001630.19203-1-mcgrof@kernel.org> <20170526211228.27764-1-mcgrof@kernel.org> <20170620205622.GX21846@wotan.suse.de> From: Kees Cook Date: Tue, 20 Jun 2017 17:23:16 -0700 X-Google-Sender-Auth: zY-goUh4uMOrD2cF_pKZYXav3Us Message-ID: Subject: Re: [PATCH v3 0/4] kmod: help make deterministic To: "Luis R. Rodriguez" Cc: Andrew Morton , Jessica Yu , Shuah Khan , Rusty Russell , "Eric W. Biederman" , Dmitry Torokhov , Arnaldo Carvalho de Melo , Jonathan Corbet , Josh Triplett , martin.wilck@suse.com, Michal Marek , Petr Mladek , hare , rwright@hpe.com, Jeff Mahoney , David Sterba , Filipe Manana , NeilBrown , Guenter Roeck , rgoldwyn@suse.com, Subash Abhinov Kasiviswanathan , Heinrich Schuchardt , Aaron Tomlin , Miroslav Benes , "Paul E. McKenney" , Dan Williams , Josh Poimboeuf , "David S. Miller" , Ingo Molnar , Alan Cox , "Ted Ts'o" , Greg KH , Linus Torvalds , linux-kselftest@vger.kernel.org, "linux-doc@vger.kernel.org" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1548 Lines: 37 On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: >> This v3 nukes the proc sysctl interface in favor for just letting userspace >> just check kernel revision. Prior to whenever this is merged userspace should >> try to avoid hammering more than 50 kmod threads as they can fail and it'd >> get -ENOMEM. >> >> We do away with the old heuristics on assuming you could end up with >> less than max_threads/2 < 50 threads as Dmitry notes this would mean having >> a system with 16 MiB of RAM with modules enabled. It simplifies our patch >> "kmod: reduce atomic operations on kmod_concurrent" considerbly. >> >> Since the sysctl interface is gone, this no longer depends on any >> other patches, the series is independent. As usual the series is >> available on my linux-next 20170526-kmod-only branch which is based >> on next-20170526. >> >> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20170526-kmod-only >> >> Luis >> >> Luis R. Rodriguez (4): >> module: use list_for_each_entry_rcu() on find_module_all() >> kmod: reduce atomic operations on kmod_concurrent and simplify >> kmod: add test driver to stress test the module loader >> kmod: throttle kmod thread limit > > About a month now with no further nitpicks. What tree should these changes > go through if there are no issues? Andrew's, Jessica's ? Seems like going through Jessica's would make the most sense? -Kees -- Kees Cook Pixel Security