Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753025AbdFUBHo (ORCPT ); Tue, 20 Jun 2017 21:07:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:45078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbdFUBHm (ORCPT ); Tue, 20 Jun 2017 21:07:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B5702395F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 20 Jun 2017 22:07:39 -0300 From: Arnaldo Carvalho de Melo To: Milian Wolff Cc: Ravi Bangoria , Mark Wielaard , Paolo Bonzini , linux-kernel@vger.kernel.org, "Naveen N. Rao" , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] perf: libdw support for powerpc [ping] Message-ID: <20170621010739.GL13640@kernel.org> References: <1496312681-20133-1-git-send-email-pbonzini@redhat.com> <1497354282.3755.201.camel@klomp.org> <59400ADD.4090709@linux.vnet.ibm.com> <3621613.kMnvz8Tm3d@milian-kdab2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3621613.kMnvz8Tm3d@milian-kdab2> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 21 Em Thu, Jun 15, 2017 at 10:46:16AM +0200, Milian Wolff escreveu: > On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > Just a quick question: Have you guys applied my recent patch: > commit 5ea0416f51cc93436bbe497c62ab49fd9cb245b6 > Author: Milian Wolff > Date: Thu Jun 1 23:00:21 2017 +0200 > perf report: Include partial stacks unwound with libdw > So far the whole stack was thrown away when any error occurred before > the maximum stack depth was unwound. This is actually a very common > scenario though. The stacks that got unwound so far are still > interesting. This removes a large chunk of differences when comparing > perf script output for libunwind and libdw perf unwinding. > > If not, then this could explain the issue you are seeing. Hi Millian, can I take this as an Acked-by or Tested-by? - Arnaldo