Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbdFUBRT (ORCPT ); Tue, 20 Jun 2017 21:17:19 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49548 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753007AbdFUBRR (ORCPT ); Tue, 20 Jun 2017 21:17:17 -0400 Date: Tue, 20 Jun 2017 21:17:13 -0400 (EDT) Message-Id: <20170620.211713.1253498659679389459.davem@davemloft.net> To: felix.manlunas@cavium.com Cc: Derek.Chickles@cavium.com, dvlasenk@redhat.com, netdev@vger.kernel.org, Prasad.Kanneganti@cavium.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data From: David Miller In-Reply-To: <20170620205125.GA1364@felix-thinkpad.cavium.com> References: <20170620.152142.1443468587541525646.davem@davemloft.net> <20170620205125.GA1364@felix-thinkpad.cavium.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Jun 2017 17:35:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 36 From: Felix Manlunas Date: Tue, 20 Jun 2017 13:51:25 -0700 > From: Derek Chickles > Date: Tue, 20 Jun 2017 13:15:34 -0700 > >> > From: David Miller [mailto:davem@davemloft.net] >> > Sent: Tuesday, June 20, 2017 12:22 PM >> > >> > From: Denys Vlasenko >> > Date: Mon, 19 Jun 2017 21:50:52 +0200 >> > >> > > Only compile-tested - I don't have the hardware. >> > > >> > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt >> > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned >> > > anyway. >> > > >> > > Signed-off-by: Denys Vlasenko >> > >> > Looks good to me but I'll let one of the liquidio guys review this first >> > before I apply it. >> >> Felix is going to try this out this week to confirm. Let's wait for his ack. > > This patch works. I tested it with a LiquidIO II adapter. > > ACK Please ACK patches in the standard way which is in the form of: Acked-by: David S. Miller This tag is recognized by tools and in particular the patchwork site where networking patches are maintained, automatically including your ACK into the patch I apply.