Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbdFUCf7 (ORCPT ); Tue, 20 Jun 2017 22:35:59 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:36473 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753057AbdFUCf5 (ORCPT ); Tue, 20 Jun 2017 22:35:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <359d62c1f2f7ef61c6160df9b60c1af4bfcea89a.1496664241.git.baolin.wang@spreadtrum.com> <20170612060718.GA8566@spreadtrum.com> From: Baolin Wang Date: Wed, 21 Jun 2017 10:35:56 +0800 Message-ID: Subject: Re: [PATCH v2 1/2] DT: pinctrl: Add binding documentation for Spreadtrum pin controller To: Linus Walleij Cc: Mark Rutland , Rob Herring , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 829 Lines: 24 On 20 June 2017 at 17:10, Linus Walleij wrote: > On Mon, Jun 12, 2017 at 8:07 AM, Baolin Wang wrote: > >> I agree we should add these into core code, something like: >> static const struct pinconf_generic_params dt_params[] = { > (...) >> { "slew-rate", PIN_CONFIG_SLEW_RATE, 0 }, >> + { "sleep-bias-pull-up", PIN_CONFIG_SLEEP_BIAS_PULL_UP, 1}, >> + { "sleep-bias-pull-down", PIN_CONFIG_SLEEP_BIAS_PULL_DOWN 1}, >> ...... >> }; >> >> If you agree that, I can help to add these configuration. > > Actually, yes indeed, that is a nice thing. Very nice. I think my Nomadik > driver could use this too. > > Just need to hear what the DT maintainers have to say about it. OK, I will submit one patch to review. Thanks. -- Baolin.wang Best Regards