Date: Tue, 20 Jun 2017 19:59:03 -0700
From: Felix Manlunas <felix.manlunas@cavium.com>
To: David Miller <davem@davemloft.net>
Cc: Derek.Chickles@cavium.com, dvlasenk@redhat.com, netdev@vger.kernel.org,
        Prasad.Kanneganti@cavium.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in
 .data
Message-ID: <20170621025903.GA1261@felix-thinkpad.cavium.com>
References: <20170620.152142.1443468587541525646.davem@davemloft.net>
 <MWHPR07MB29434F09FBC054D2E0310D6FF3C50@MWHPR07MB2943.namprd07.prod.outlook.com>
 <20170620205125.GA1364@felix-thinkpad.cavium.com>
 <20170620.211713.1253498659679389459.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170620.211713.1253498659679389459.davem@davemloft.net>
User-Agent: Mutt/1.6.1 (2016-04-27)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 02:59:08.0447 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3177
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1439
Lines: 41

From: David Miller <davem@davemloft.net>
Date: Tue, 20 Jun 2017 21:17:13 -0400

> From: Felix Manlunas <felix.manlunas@cavium.com>
> Date: Tue, 20 Jun 2017 13:51:25 -0700
> 
> > From: Derek Chickles <Derek.Chickles@cavium.com>
> > Date: Tue, 20 Jun 2017 13:15:34 -0700
> > 
> >> > From: David Miller [mailto:davem@davemloft.net]
> >> > Sent: Tuesday, June 20, 2017 12:22 PM
> >> > 
> >> > From: Denys Vlasenko <dvlasenk@redhat.com>
> >> > Date: Mon, 19 Jun 2017 21:50:52 +0200
> >> > 
> >> > > Only compile-tested - I don't have the hardware.
> >> > >
> >> > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt
> >> > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned
> >> > > anyway.
> >> > >
> >> > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> >> > 
> >> > Looks good to me but I'll let one of the liquidio guys review this first
> >> > before I apply it.
> >> 
> >> Felix is going to try this out this week to confirm. Let's wait for his ack.
> > 
> > This patch works.  I tested it with a LiquidIO II adapter.
> > 
> > ACK
> 
> Please ACK patches in the standard way which is in the form of:
> 
> Acked-by: David S. Miller <davem@davemloft.net>
> 
> This tag is recognized by tools and in particular the patchwork
> site where networking patches are maintained, automatically
> including your ACK into the patch I apply.

Acked-by: Felix Manlunas <felix.manlunas@cavium.com>