Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbdFUDBl (ORCPT ); Tue, 20 Jun 2017 23:01:41 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:32274 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753141AbdFUDBj (ORCPT ); Tue, 20 Jun 2017 23:01:39 -0400 Message-ID: <1498014092.810.3.camel@mtkswgap22> Subject: Re: [PATCH] arm64: dts: Delete unused dummy clocks From: Mars Cheng To: Matthias Brugger CC: , , , , , , , , Date: Wed, 21 Jun 2017 11:01:32 +0800 In-Reply-To: <20170620102854.9346-1-matthias.bgg@gmail.com> References: <20170620102854.9346-1-matthias.bgg@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1306 Lines: 50 Hi Matthias On Tue, 2017-06-20 at 12:28 +0200, Matthias Brugger wrote: > After adding the clock subsystem to the SOC, the dummy > clocks clk26m and clk32k are not longer needed. Delete them. > > Signed-off-by: Matthias Brugger > --- > arch/arm64/boot/dts/mediatek/mt6797.dtsi | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt6797.dtsi b/arch/arm64/boot/dts/mediatek/mt6797.dtsi > index 3512c8e6dc65..09d46befa86b 100644 > --- a/arch/arm64/boot/dts/mediatek/mt6797.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt6797.dtsi > @@ -102,20 +102,6 @@ > }; > }; > > - clk26m: oscillator@0 { > - compatible = "fixed-clock"; > - #clock-cells = <0>; > - clock-frequency = <26000000>; > - clock-output-names = "clk26m"; > - }; clk26m is referenced by drivers/clk/mediatek/clk-mt6797.c: static const char * const axi_parents[] = { "clk26m", "syspll_d7", "ulposc_axi_ck_mux", }; Please just delete clk32k which is dummy, and keep clk26m. Or might get PLL wrongly. Thanks. > - > - clk32k: oscillator@1 { > - compatible = "fixed-clock"; > - #clock-cells = <0>; > - clock-frequency = <32000>; > - clock-output-names = "clk32k"; > - }; > - > timer { > compatible = "arm,armv8-timer"; > interrupt-parent = <&gic>;