Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751088AbdFUGBa (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Jun 2017 02:01:30 -0400
Received: from mail-yw0-f193.google.com ([209.85.161.193]:36374 "EHLO
        mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750753AbdFUGB3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Jun 2017 02:01:29 -0400
MIME-Version: 1.0
In-Reply-To: <1497864405-26990-4-git-send-email-jk@ozlabs.org>
References: <1497864405-26990-1-git-send-email-jk@ozlabs.org> <1497864405-26990-4-git-send-email-jk@ozlabs.org>
From: Joel Stanley <joel@jms.id.au>
Date: Wed, 21 Jun 2017 15:31:07 +0930
X-Google-Sender-Auth: FLtg90jVWqv5CP5CT9TLw9HAxdk
Message-ID: <CACPK8XcVH19nYRP85T6rX1D3jd+1C4kr09DW3W_9kf1DJjj49Q@mail.gmail.com>
Subject: Re: [PATCH 3/3] fsi/master-gpio: Add external mode
To: Jeremy Kerr <jk@ozlabs.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Christopher Bostic <cbostic@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 583
Lines: 21

Hi Jeremy,

On Mon, Jun 19, 2017 at 6:56 PM, Jeremy Kerr <jk@ozlabs.org> wrote:
> This change introduces an 'external mode' for GPIO-based FSI masters,
> +static ssize_t external_mode_show(struct device *dev,
> +               struct device_attribute *attr, char *buf)
> +{
> +       struct fsi_master_gpio *master = dev_get_drvdata(dev);
> +
> +       return snprintf(buf, PAGE_SIZE - 1, "%u",

I gave this a spin on a machine today and noticed we're missing a
newline there. Should this be "%u\n"?

Cheers,

Joel

> +                       master->external_mode ? 1 : 0);
> +}
> +