Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdFUGIH (ORCPT ); Wed, 21 Jun 2017 02:08:07 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:34766 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbdFUGIF (ORCPT ); Wed, 21 Jun 2017 02:08:05 -0400 MIME-Version: 1.0 In-Reply-To: <5949C274.6050806@rock-chips.com> References: <1497964080-27301-1-git-send-email-bhumirks@gmail.com> <1497964080-27301-2-git-send-email-bhumirks@gmail.com> <5949C274.6050806@rock-chips.com> From: Bhumika Goyal Date: Wed, 21 Jun 2017 11:38:04 +0530 Message-ID: Subject: Re: [PATCH 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures To: Mark yao Cc: Julia Lawall , maxime.ripard@free-electrons.com, airlied@linux.ie, Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Heiko_St=C3=BCbner?= , linux-rockchip@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5L68BD7029971 Content-Length: 2409 Lines: 69 On Wed, Jun 21, 2017 at 6:18 AM, Mark yao wrote: > On 2017年06月20日 21:07, Bhumika Goyal wrote: >> >> Add const to drm_encoder_helper_funcs structures as they are only passed >> as an argument to the function drm_encoder_helper_add and this argument >> is of type const. So, add const to these structures. Also, fix line over >> 80 characters warning while adding const. >> >> Signed-off-by: Bhumika Goyal >> --- >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 3 ++- >> drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> index 9606121..96c6c10 100644 >> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> @@ -252,7 +252,8 @@ rockchip_dp_drm_encoder_atomic_check(struct >> drm_encoder *encoder, >> return 0; >> } >> -static struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs >> = { >> +static >> +const struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = >> { > > > I don't think split static and const into two line is a good idea, it's > ugly. I'm ok over 80 characters with good-looking. > Or split like following: > static const struct drm_encoder_helper_funcs > rockchip_dp_encoder_helper_funcs = { > Okay, so I will let the line exceed over 80 characters and send a v2. Thanks, Bhumika >> .mode_fixup = rockchip_dp_drm_encoder_mode_fixup, >> .mode_set = rockchip_dp_drm_encoder_mode_set, >> .enable = rockchip_dp_drm_encoder_enable, >> diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c >> b/drivers/gpu/drm/rockchip/inno_hdmi.c >> index 7d9b75e..4ab9fad 100644 >> --- a/drivers/gpu/drm/rockchip/inno_hdmi.c >> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c >> @@ -530,7 +530,7 @@ inno_hdmi_encoder_atomic_check(struct drm_encoder >> *encoder, >> return 0; >> } >> -static struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = >> { >> +static const struct drm_encoder_helper_funcs >> inno_hdmi_encoder_helper_funcs = { >> .enable = inno_hdmi_encoder_enable, >> .disable = inno_hdmi_encoder_disable, >> .mode_fixup = inno_hdmi_encoder_mode_fixup, > > > Thanks > > -- > Ｍark Yao > >