Message-ID: <594A185E.4060709@huawei.com>
Date: Wed, 21 Jun 2017 14:55:26 +0800
From: zhouchengming <zhouchengming1@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
CC: <mingo@redhat.com>, <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, <acme@kernel.org>,
        <guohanjun@huawei.com>
Subject: Re: [PATCH] perf/core: make sure group events are for the same cpu
References: <1497685332-122353-1-git-send-email-zhouchengming1@huawei.com> <874lvaztzw.fsf@ashishki-desk.ger.corp.intel.com>
In-Reply-To: <874lvaztzw.fsf@ashishki-desk.ger.corp.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 689
Lines: 30

On 2017/6/20 21:08, Alexander Shishkin wrote:
> Zhou Chengming<zhouchengming1@huawei.com>  writes:
>
>> The else branch are broken for taskctx:
> This is not a good way to open a commit message.
>
>> two events can on the same taskctx, but on different cpu.
> How?

fd1 = perf_open_event(attr, pid, 0, -1, flags);
fd2 = perf_open_event(attr, pid, 1, fd1, flags);

fd1 will be the leader event,  fd2 will be the sibling event in the group.

And they are for the same task, so they will be put on the same taskctx successfully
if !move_group.

Obviously it's wrong, we can't concurrently schedule them as a group, since they are
on different cpu.

Thanks.

>
> Regards,
> --
> Alex
>
> .
>