Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbdFUHHE (ORCPT ); Wed, 21 Jun 2017 03:07:04 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34798 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752489AbdFUHHC (ORCPT ); Wed, 21 Jun 2017 03:07:02 -0400 Date: Wed, 21 Jun 2017 09:06:58 +0200 From: Daniel Vetter To: Arvind Yadav Cc: linux@armlinux.org.uk, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: armada: make of_device_ids const. Message-ID: <20170621070658.6kamcwsy25l6altm@phenom.ffwll.local> Mail-Followup-To: Arvind Yadav , linux@armlinux.org.uk, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1576 Lines: 47 On Tue, Jun 20, 2017 at 10:44:33AM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 8836 744 0 9580 256c drivers/gpu/drm/armada/armada_crtc.o > > File size after constify armada_lcd_of_match: > text data bss dec hex filename > 9220 328 0 9548 254c drivers/gpu/drm/armada/armada_crtc.o > > Signed-off-by: Arvind Yadav Applied to drm-misc-next, thanks. -Daniel > --- > drivers/gpu/drm/armada/armada_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c > index 4fe19fd..94b76bd 100644 > --- a/drivers/gpu/drm/armada/armada_crtc.c > +++ b/drivers/gpu/drm/armada/armada_crtc.c > @@ -1364,7 +1364,7 @@ static int armada_lcd_remove(struct platform_device *pdev) > return 0; > } > > -static struct of_device_id armada_lcd_of_match[] = { > +static const struct of_device_id armada_lcd_of_match[] = { > { > .compatible = "marvell,dove-lcd", > .data = &armada510_ops, > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch