Date: Wed, 21 Jun 2017 07:09:42 +0000
From: Jayachandran C <jnair@caviumnetworks.com>
To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
Cc: linux-acpi@vger.kernel.org, devel@acpica.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        lv.zheng@intel.com, robert.moore@intel.com, marc.zyngier@arm.com,
        catalin.marinas@arm.com, will.deacon@arm.com,
        lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, tglx@linutronix.de,
        jason@lakedaemon.net, gpkulkarni@gmail.com
Subject: Re: [PATCH v3 2/2] acpi, gicv3-its, numa: Adding numa node mapping
 for gic-its units
Message-ID: <20170621070941.GA6124@localhost>
References: <1498025743-6340-1-git-send-email-ganapatrao.kulkarni@cavium.com>
 <1498025743-6340-3-git-send-email-ganapatrao.kulkarni@cavium.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1498025743-6340-3-git-send-email-ganapatrao.kulkarni@cavium.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 07:09:50.9930 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB1068
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3867
Lines: 131

On Wed, Jun 21, 2017 at 11:45:43AM +0530, Ganapatrao Kulkarni wrote:
> Add code to parse SRAT ITS Affinity sub table as defined in ACPI 6.2
> Later in per device probe, ITS devices are mapped to
> numa node using ITS id to proximity domain mapping.
> 
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 80 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 79 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 45ea1933..88cfb32 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -1833,6 +1833,82 @@ static int __init its_of_probe(struct device_node *node)
>  
>  #define ACPI_GICV3_ITS_MEM_SIZE (SZ_128K)
>  
> +#ifdef CONFIG_ACPI_NUMA
> +struct its_srat_map {
> +	u32	numa_node;  /* numa node id */
> +	u32	its_id;  /* GIC ITS ID */
> +};
> +
> +static struct its_srat_map its_srat_maps[MAX_NUMNODES] __initdata = {
> +	[0 ... MAX_NUMNODES - 1] = {NUMA_NO_NODE, UINT_MAX} };
> +
> +static int its_in_srat __initdata;
> +
> +static int __init
> +acpi_get_its_numa_node(u32 its_id)
> +{
> +	int i;
> +
> +	for (i = 0; i < its_in_srat; i++) {
> +		if (its_id == its_srat_maps[i].its_id)
> +			return its_srat_maps[i].numa_node;
> +	}
> +	return NUMA_NO_NODE;
> +}
> +
> +static int __init
> +gic_acpi_parse_srat_its(struct acpi_subtable_header *header,
> +			 const unsigned long end)
> +{
> +	int pxm, node;
> +	struct acpi_srat_its_affinity *its_affinity;
> +
> +	its_affinity = (struct acpi_srat_its_affinity *)header;
> +	if (!its_affinity)
> +		return -EINVAL;
> +
> +	if (its_affinity->header.length <
> +			sizeof(struct acpi_srat_its_affinity)) {
> +		pr_err("SRAT:ITS: Invalid SRAT header length: %d\n",
> +			its_affinity->header.length);

The original driver does not use pr_fmt properly, it may be worth
fixing that up rather than having prefixes, here...

> +		return -EINVAL;
> +	}
> +
> +	if (its_in_srat >= MAX_NUMNODES) {
> +		pr_err("SRAT:ITS: ITS devices exceeding max count[%d]\n",
> +				MAX_NUMNODES);
> +		return -EINVAL;
> +	}
> +
> +	pxm = its_affinity->proximity_domain;
> +	node = acpi_map_pxm_to_node(pxm);
> +
> +	if (node == NUMA_NO_NODE || node >= MAX_NUMNODES) {
> +		pr_err("SRAT:ITS: Invalid numa node %d\n", node);

here.

> +		return -EINVAL;
> +	}
> +
> +	its_srat_maps[its_in_srat].numa_node = node;
> +	its_srat_maps[its_in_srat].its_id = its_affinity->its_id;
> +	its_in_srat++;
> +	pr_info("ACPI: NUMA: SRAT: ITS: PXM %d -> ITS_ID %d -> NODE %d\n",
> +		pxm, its_affinity->its_id, node);

also here.

> +
> +	return 0;
> +}
> +
> +static int __init acpi_table_parse_srat_its(void)
> +{
> +	return acpi_table_parse_entries(ACPI_SIG_SRAT,
> +					sizeof(struct acpi_table_srat),
> +					ACPI_SRAT_TYPE_GIC_ITS_AFFINITY,
> +					gic_acpi_parse_srat_its, 0);
> +}
> +#else
> +#define acpi_table_parse_srat_its()	do { } while (0)

The function implementation returns a value, but this does not, it is
better to be consistent here.

> +#define acpi_get_its_numa_node(its_id)	NUMA_NO_NODE
> +#endif
> +
>  static int __init gic_acpi_parse_madt_its(struct acpi_subtable_header *header,
>  					  const unsigned long end)
>  {
> @@ -1861,7 +1937,8 @@ static int __init gic_acpi_parse_madt_its(struct acpi_subtable_header *header,
>  		goto dom_err;
>  	}
>  
> -	err = its_probe_one(&res, dom_handle, NUMA_NO_NODE);
> +	err = its_probe_one(&res, dom_handle,
> +			acpi_get_its_numa_node(its_entry->translation_id));
>  	if (!err)
>  		return 0;
>  
> @@ -1873,6 +1950,7 @@ static int __init gic_acpi_parse_madt_its(struct acpi_subtable_header *header,
>  
>  static void __init its_acpi_probe(void)
>  {
> +	acpi_table_parse_srat_its();
>  	acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
>  			      gic_acpi_parse_madt_its, 0);
>  }

JC.