Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbdFUHuc (ORCPT ); Wed, 21 Jun 2017 03:50:32 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:34366 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbdFUHua (ORCPT ); Wed, 21 Jun 2017 03:50:30 -0400 X-IronPort-AV: E=Sophos;i="5.39,368,1493708400"; d="scan'208";a="1586708" Subject: Re: [PATCH v5 1/4] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin To: Eugen Hristev , CC: Jonathan Cameron , , , , , , , References: <1497533097-12052-1-git-send-email-eugen.hristev@microchip.com> <1497533097-12052-2-git-send-email-eugen.hristev@microchip.com> <20170620175552.2ec49c56@kernel.org> From: Nicolas Ferre Organization: microchip Message-ID: <09e9462b-f375-2259-179f-0a723b2cb5aa@microchip.com> Date: Wed, 21 Jun 2017 09:50:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170620175552.2ec49c56@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1986 Lines: 65 On 20/06/2017 at 18:55, Jonathan Cameron wrote: > On Thu, 15 Jun 2017 16:24:54 +0300 > Eugen Hristev wrote: > >> Enable pinctrl for ADTRG pin (PD31) for ADC hardware trigger support. >> >> Signed-off-by: Eugen Hristev >> Acked-by: Ludovic Desroches > The driver changes are on their way upstream. > > Acked-by: Jonathan Cameron Thanks Jonathan, Acked-by: Nicolas Ferre Eugen, note that we may need to wait for 4.14 as our changes for 4.13 are already queued in arm-soc... Best regards, >> --- >> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 +++++++++++++++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts >> index 0bef9e0..04754b1 100644 >> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts >> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts >> @@ -303,7 +303,7 @@ >> vddana-supply = <&vdd_3v3_lp_reg>; >> vref-supply = <&vdd_3v3_lp_reg>; >> pinctrl-names = "default"; >> - pinctrl-0 = <&pinctrl_adc_default>; >> + pinctrl-0 = <&pinctrl_adc_default &pinctrl_adtrg_default>; >> status = "okay"; >> }; >> >> @@ -322,6 +322,20 @@ >> bias-disable; >> }; >> >> + /* >> + * The ADTRG pin can work on any edge type. >> + * In here it's being pulled up, so need to >> + * connect it to ground to get an edge e.g. >> + * Trigger can be configured on falling, rise >> + * or any edge, and the pull-up can be changed >> + * to pull-down or left floating according to >> + * needs. >> + */ >> + pinctrl_adtrg_default: adtrg_default { >> + pinmux = ; >> + bias-pull-up; >> + }; >> + >> pinctrl_charger_chglev: charger_chglev { >> pinmux = ; >> bias-disable; > > -- Nicolas Ferre