Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751953AbdFUJAn (ORCPT ); Wed, 21 Jun 2017 05:00:43 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54699 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbdFUJAl (ORCPT ); Wed, 21 Jun 2017 05:00:41 -0400 Date: Wed, 21 Jun 2017 11:00:31 +0200 From: Michael Holzheu To: Xunlei Pang Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, akpm@linux-foundation.org, Eric Biederman , Dave Young , Baoquan He , linux-s390@vger.kernel.org, Dave Anderson , Hari Bathini , Gustavo Luiz Duarte , Mikhail Zaslonko Subject: Re: [PATCH] s390/crash: Fix KEXEC_NOTE_BYTES definition In-Reply-To: <1496974625-10891-1-git-send-email-xlpang@redhat.com> References: <1496974625-10891-1-git-send-email-xlpang@redhat.com> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17062109-0040-0000-0000-000003AF8F01 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062109-0041-0000-0000-000025A93882 Message-Id: <20170621110031.76c15516@TP-holzheu> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-21_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706210150 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3456 Lines: 100 Hi Xunlei, Sorry for the late reply - I was on vacation up to now. Give us some time to look into this issue. Michael Am Fri, 9 Jun 2017 10:17:05 +0800 schrieb Xunlei Pang : > S390 KEXEC_NOTE_BYTES is not used by note_buf_t as before, which > is now defined as follows: > typedef u32 note_buf_t[CRASH_CORE_NOTE_BYTES/4]; > It was changed by the CONFIG_CRASH_CORE feature. > > This patch gets rid of all the old KEXEC_NOTE_BYTES stuff, and > renames KEXEC_NOTE_BYTES to CRASH_CORE_NOTE_BYTES for S390. > > Fixes: 692f66f26a4c ("crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE") > Cc: Dave Young > Cc: Dave Anderson > Cc: Hari Bathini > Cc: Gustavo Luiz Duarte > Signed-off-by: Xunlei Pang > --- > arch/s390/include/asm/kexec.h | 2 +- > include/linux/crash_core.h | 7 +++++++ > include/linux/kexec.h | 11 +---------- > 3 files changed, 9 insertions(+), 11 deletions(-) > > diff --git a/arch/s390/include/asm/kexec.h b/arch/s390/include/asm/kexec.h > index 2f924bc..352deb8 100644 > --- a/arch/s390/include/asm/kexec.h > +++ b/arch/s390/include/asm/kexec.h > @@ -47,7 +47,7 @@ > * Seven notes plus zero note at the end: prstatus, fpregset, timer, > * tod_cmp, tod_reg, control regs, and prefix > */ > -#define KEXEC_NOTE_BYTES \ > +#define CRASH_CORE_NOTE_BYTES \ > (ALIGN(sizeof(struct elf_note), 4) * 8 + \ > ALIGN(sizeof("CORE"), 4) * 7 + \ > ALIGN(sizeof(struct elf_prstatus), 4) + \ > diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h > index e9de6b4..dbc6e5c 100644 > --- a/include/linux/crash_core.h > +++ b/include/linux/crash_core.h > @@ -10,9 +10,16 @@ > #define CRASH_CORE_NOTE_NAME_BYTES ALIGN(sizeof(CRASH_CORE_NOTE_NAME), 4) > #define CRASH_CORE_NOTE_DESC_BYTES ALIGN(sizeof(struct elf_prstatus), 4) > > +/* > + * The per-cpu notes area is a list of notes terminated by a "NULL" > + * note header. For kdump, the code in vmcore.c runs in the context > + * of the second kernel to combine them into one note. > + */ > +#ifndef CRASH_CORE_NOTE_BYTES > #define CRASH_CORE_NOTE_BYTES ((CRASH_CORE_NOTE_HEAD_BYTES * 2) + \ > CRASH_CORE_NOTE_NAME_BYTES + \ > CRASH_CORE_NOTE_DESC_BYTES) > +#endif > > #define VMCOREINFO_BYTES PAGE_SIZE > #define VMCOREINFO_NOTE_NAME "VMCOREINFO" > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > index 3ea8275..133df03 100644 > --- a/include/linux/kexec.h > +++ b/include/linux/kexec.h > @@ -14,7 +14,6 @@ > > #if !defined(__ASSEMBLY__) > > -#include > #include > > #include > @@ -25,6 +24,7 @@ > #include > #include > #include > +#include > > /* Verify architecture specific macros are defined */ > > @@ -63,15 +63,6 @@ > #define KEXEC_CORE_NOTE_NAME CRASH_CORE_NOTE_NAME > > /* > - * The per-cpu notes area is a list of notes terminated by a "NULL" > - * note header. For kdump, the code in vmcore.c runs in the context > - * of the second kernel to combine them into one note. > - */ > -#ifndef KEXEC_NOTE_BYTES > -#define KEXEC_NOTE_BYTES CRASH_CORE_NOTE_BYTES > -#endif > - > -/* > * This structure is used to hold the arguments that are used when loading > * kernel binaries. > */