Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764AbdFUJmD (ORCPT ); Wed, 21 Jun 2017 05:42:03 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:55318 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbdFUJl7 (ORCPT ); Wed, 21 Jun 2017 05:41:59 -0400 Date: Wed, 21 Jun 2017 11:41:46 +0200 From: Alexandre Belloni To: Russell King - ARM Linux Cc: Pavel Machek , Thomas Gleixner , Benjamin Gaignard , Baruch Siach , "patches@opensource.wolfsonmicro.com" , Linus Walleij , "linux-tegra@vger.kernel.org" , Thierry Reding , "x86@kernel.org" , Jonathan Hunter , Chen-Yu Tsai , Ingo Molnar , Sylvain Lemieux , Sebastian Hesselbarth , Len Brown , "linaro-kernel@lists.linaro.org" , Jason Cooper , "rtc-linux@googlegroups.com" , "linux-pm@vger.kernel.org" , Hans Ulli Kroll , "adi-buildroot-devel@lists.sourceforge.net" , Vladimir Zapolskiy , John Stultz , Gregory Clement , Michael Chan , "linux-arm-kernel@lists.infradead.org" , Alessandro Zummo , Barry Song , Support Opensource , "netdev@vger.kernel.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Steve Twiss , Maxime Ripard Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Message-ID: <20170621094146.ebq5hxuvtmfdgekz@piout.net> References: <20170620213507.urobmtg34vzubrdq@piout.net> <20170621075152.GA15996@amd> <20170621083907.y3gadsmsoufa5niv@piout.net> <20170621091948.GP4902@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170621091948.GP4902@n2100.armlinux.org.uk> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 32 On 21/06/2017 at 10:19:49 +0100, Russell King - ARM Linux wrote: > On Wed, Jun 21, 2017 at 10:39:07AM +0200, Alexandre Belloni wrote: > > On 21/06/2017 at 09:51:52 +0200, Pavel Machek wrote: > > > If someone uses different threshold, well, there will be > > > confusion. But only for users that have their rtc set to the past, > > > which is quite unusual. > > > > > > > Or not, having an RTC set in the past is actually quite common. I'd find > > it weird to have a new device boot and be set to a date in the future. > > ... and that basically means you can't use hardware that stores RTC > time as a 32-bit number of seconds past 2106. > And I guess it will not matter much for us anyway ;) > > Also note that the threshold or offset thing may seem like a good idea > > but fails with many RTCs because of how they handle leap years. > > Not for the case being discussed. A 32-bit counter of seconds knows > nothing about leap years - all that is handled by the conversion > functions. > Well, the patch series touches some RTCs that are not using 32 bit counter so I though I might as well raise the issue now. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com