Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbdFUMWh (ORCPT ); Wed, 21 Jun 2017 08:22:37 -0400 Received: from nbd.name ([46.4.11.11]:44438 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbdFUMWf (ORCPT ); Wed, 21 Jun 2017 08:22:35 -0400 Subject: Re: [PATCH RESEND 4/4] pwm: mediatek: add MT2712/MT7622 support To: Zhi Mao , Thierry Reding , Rob Herring , Mark Rutland , Matthias Brugger , linux-pwm@vger.kernel.org References: <1498032672-7172-1-git-send-email-zhi.mao@mediatek.com> <1498032672-7172-5-git-send-email-zhi.mao@mediatek.com> Cc: zhenbao.liu@mediatek.com, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, yt.shen@mediatek.com, yingjoe.chen@mediatek.com, linux-arm-kernel@lists.infradead.org From: John Crispin Message-ID: <4600cf23-5e59-df02-37dc-056cb4a9744c@phrozen.org> Date: Wed, 21 Jun 2017 14:22:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <1498032672-7172-5-git-send-email-zhi.mao@mediatek.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1824 Lines: 61 On 21/06/17 10:11, Zhi Mao wrote: > support multiple chip(MT2712, MT7622, MT7623) This patch does more than add extra SoC support. It also * adds PWM_CLK_DIV_MAX which really should go into its own patch * adds mtk_pwm_com_reg which should also go into its own patch more comments inline > > Signed-off-by: Zhi Mao > --- > drivers/pwm/pwm-mediatek.c | 63 +++++++++++++++++++++++++++++++++++--------- > 1 file changed, 51 insertions(+), 12 deletions(-) > > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c > index c803ff6..d520356 100644 > --- a/drivers/pwm/pwm-mediatek.c > +++ b/drivers/pwm/pwm-mediatek.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include [...] > @@ -215,9 +238,25 @@ static int mtk_pwm_remove(struct platform_device *pdev) > return pwmchip_remove(&pc->chip); > } > > +/*==========================================*/ please remove these comment lines John > +static const struct mtk_com_pwm_data mt2712_pwm_data = { > + .pwm_nums = 8, > +}; > + > +static const struct mtk_com_pwm_data mt7622_pwm_data = { > + .pwm_nums = 6, > +}; > + > +static const struct mtk_com_pwm_data mt7623_pwm_data = { > + .pwm_nums = 5, > +}; > +/*==========================================*/ > + > static const struct of_device_id mtk_pwm_of_match[] = { > - { .compatible = "mediatek,mt7623-pwm" }, > - { } > + {.compatible = "mediatek,mt2712-pwm", .data = &mt2712_pwm_data}, > + {.compatible = "mediatek,mt7622-pwm", .data = &mt7622_pwm_data}, > + {.compatible = "mediatek,mt7623-pwm", .data = &mt7623_pwm_data}, > + {}, > }; > MODULE_DEVICE_TABLE(of, mtk_pwm_of_match); >