Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbdFUOTU (ORCPT ); Wed, 21 Jun 2017 10:19:20 -0400 Received: from mail.kdab.com ([176.9.126.58]:48158 "EHLO mail.kdab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbdFUOTT (ORCPT ); Wed, 21 Jun 2017 10:19:19 -0400 From: Milian Wolff To: Arnaldo Carvalho de Melo Cc: Ravi Bangoria , Mark Wielaard , Paolo Bonzini , linux-kernel@vger.kernel.org, "Naveen N. Rao" , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] perf: libdw support for powerpc [ping] Date: Wed, 21 Jun 2017 16:19:11 +0200 Message-ID: <3364571.STeM6x1sE0@agathebauer> Organization: KDAB (Deutschland) GmbH&Co KG, a KDAB Group company In-Reply-To: <20170621124829.GM13640@kernel.org> References: <1496312681-20133-1-git-send-email-pbonzini@redhat.com> <1632232.7qGxppV1HK@agathebauer> <20170621124829.GM13640@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 34 On Mittwoch, 21. Juni 2017 14:48:29 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 21, 2017 at 10:16:56AM +0200, Milian Wolff escreveu: > > On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > > > Hi Millian, can I take this as an Acked-by or Tested-by? > > > > I have no access to any PowerPC hardware. In principle the code looks > > fine, but that's all I can say here. > > Ok, that would count as an Acked-by, i.e. from > Documentation/process/submitting-patches.rst: > > ------------------------- > > Acked-by: is not as formal as Signed-off-by:. It is a record that the acker > has at least reviewed the patch and has indicated acceptance. Hence patch > mergers will sometimes manually convert an acker's "yep, looks good to me" > into an Acked-by: (but note that it is usually better to ask for an > explicit ack). > > ------------------------- > > If you had a ppc machine _and_ had applied and tested the patch, that > would allow us to use a Tested-by tag. I see, I'm still unfamiliar with this process. But yes, do consider it an `Acked-by` from my side then. Cheers -- Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts