Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752862AbdFUQbR (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Jun 2017 12:31:17 -0400
Received: from smtprelay0104.hostedemail.com ([216.40.44.104]:56954 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751124AbdFUQbP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Jun 2017 12:31:15 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4605:5007:9025:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12296:12438:12555:12679:12740:12760:12895:13069:13161:13229:13311:13357:13439:14181:14659:14721:21080:21433:21451:21627:30012:30029:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: start98_61fc8108a8b5e
X-Filterd-Recvd-Size: 1948
Message-ID: <1498062671.3337.1.camel@perches.com>
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Convert printks to
 pr_<level>
From: Joe Perches <joe@perches.com>
To: simran singhal <singhalsimran0@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Wed, 21 Jun 2017 09:31:11 -0700
In-Reply-To: <20170621121932.GA24891@singhal-Inspiron-5558>
References: <20170621121932.GA24891@singhal-Inspiron-5558>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1095
Lines: 37

On Wed, 2017-06-21 at 17:49 +0530, simran singhal wrote:
> Use the current logging style.
> Coalesce formats where appropriate.
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
[]
> @@ -236,8 +236,8 @@ ieee80211_rx_frame_mgmt(struct ieee80211_device *ieee, struct sk_buff *skb,
>  
>  	#ifdef NOT_YET
>  	if (ieee->iw_mode == IW_MODE_MASTER) {
> -		printk(KERN_DEBUG "%s: Master mode not yet supported.\n",
> -		       ieee->dev->name);
> +		pr_debug("%s: Master mode not yet supported.\n",
> +			 ieee->dev->name);

FYI 1:

Conversions of
	printk(KERN_DEBUG ...)
to
	pr_debug(...)
are not equivalent.

The first one is always placed into the object code
and emitted when the logging level is set appropriately.

The second one is only emitted if dynamic_debug is enabled
or if a #define DEBUG is set.

You should mention this change in the changelog.

In any case, for this code only, I think it's probably OK.

FYI 2:

There is a script that does these conversions and a few
other things: https://lwn.net/Articles/380161/