Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762AbdFURym (ORCPT ); Wed, 21 Jun 2017 13:54:42 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:35284 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbdFURyl (ORCPT ); Wed, 21 Jun 2017 13:54:41 -0400 Date: Wed, 21 Jun 2017 13:54:39 -0400 From: Tejun Heo To: Dennis Zhou Cc: "Levin, Alexander (Sasha Levin)" , Christoph Lameter , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "kernel-team@fb.com" Subject: Re: [PATCH 1/1] percpu: fix early calls for spinlock in pcpu_stats Message-ID: <20170621175439.GA10139@htj.duckdns.org> References: <20170619232832.27116-1-dennisz@fb.com> <20170619232832.27116-5-dennisz@fb.com> <20170621161836.tv67op4hokja35bc@sasha-lappy> <20170621175245.GA99514@dennisz-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170621175245.GA99514@dennisz-mbp.dhcp.thefacebook.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 22 On Wed, Jun 21, 2017 at 01:52:46PM -0400, Dennis Zhou wrote: > From 2c06e795162cb306c9707ec51d3e1deadb37f573 Mon Sep 17 00:00:00 2001 > From: Dennis Zhou > Date: Wed, 21 Jun 2017 10:17:09 -0700 > > Commit 30a5b5367ef9 ("percpu: expose statistics about percpu memory via > debugfs") introduces percpu memory statistics. pcpu_stats_chunk_alloc > takes the spin lock and disables/enables irqs on creation of a chunk. Irqs > are not enabled when the first chunk is initialized and thus kernels are > failing to boot with kernel debugging enabled. Fixed by changing _irq to > _irqsave and _irqrestore. > > Fixes: 30a5b5367ef9 ("percpu: expose statistics about percpu memory via debugfs") > Signed-off-by: Dennis Zhou > Reported-by: Alexander Levin Applied to percpu/for-4.13. Thanks. -- tejun