Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbdFUSMs (ORCPT ); Wed, 21 Jun 2017 14:12:48 -0400 Received: from mail-ot0-f169.google.com ([74.125.82.169]:34646 "EHLO mail-ot0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdFUSMq (ORCPT ); Wed, 21 Jun 2017 14:12:46 -0400 Subject: Re: [PATCH 0/5] rtlwifi: Neatening To: Joe Perches , linux-wireless@vger.kernel.org Cc: Chaoming Li , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Larry Finger Message-ID: Date: Wed, 21 Jun 2017 13:12:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1680 Lines: 33 On 06/19/2017 03:18 PM, Joe Perches wrote: > Joe Perches (5): > rtlwifi: Use temporary ops variable to reduce code size > rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops > rtlwifi: Add and use convenience macro rtl_btc > realtek: btcoexist: Make the rtl_btc_ops struct const > realtek: rtlwifi: drivers: Use the rtl_btc convenience macro > > drivers/net/wireless/realtek/rtlwifi/base.c | 46 ++-- > .../wireless/realtek/rtlwifi/btcoexist/rtl_btc.c | 4 +- > .../wireless/realtek/rtlwifi/btcoexist/rtl_btc.h | 2 +- > drivers/net/wireless/realtek/rtlwifi/core.c | 189 ++++++++-------- > drivers/net/wireless/realtek/rtlwifi/efuse.c | 9 +- > drivers/net/wireless/realtek/rtlwifi/pci.c | 242 +++++++++++---------- > drivers/net/wireless/realtek/rtlwifi/ps.c | 83 +++---- > .../net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 3 +- > .../wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c | 4 +- > .../net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 3 +- > .../net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 3 +- > .../net/wireless/realtek/rtlwifi/rtl8821ae/fw.c | 6 +- > .../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 3 +- > drivers/net/wireless/realtek/rtlwifi/usb.c | 40 ++-- > drivers/net/wireless/realtek/rtlwifi/wifi.h | 9 +- > 15 files changed, 336 insertions(+), 310 deletions(-) > Joe, In general, I approve of your patches. Unfortunately, they will conflict with a number of changes that I am currently making. If you would like, I can merge your patches, fix the conflicts, and submit a version 2 for you. Larry