Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751818AbdFUTF6 (ORCPT ); Wed, 21 Jun 2017 15:05:58 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:33022 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbdFUTF5 (ORCPT ); Wed, 21 Jun 2017 15:05:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170619184245.GA20187@graymalkin.kudzu.us> From: Linus Torvalds Date: Wed, 21 Jun 2017 12:05:50 -0700 X-Google-Sender-Auth: orj8CouH13gNIwNJCIiJ19Txmqg Message-ID: Subject: Re: [GIT PULL] NTB bug fixes for v4.12 To: Jon Mason Cc: Linux Kernel Mailing List , linux-ntb@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 19 On Tue, Jun 20, 2017 at 7:59 AM, Jon Mason wrote: > > This was in my ntb branch since June 9th. Previously, it was based on > v4.12-rc4. Immediately prior to doing the pull request, I did a > rebase to rc6 to avoid any potential issues you might have applying > them. Please don't do that. There are valid reasons for rebasing, but "just because" is not one of them. The valid reasons are things like "I noticed that a completely broken patch had made it into my queue, so I rebased to remove it" or similar. One common theme for valid reasons tends to be "..and I needed to rerun all the testing", so in general I get very suspicious if things are very recent, because clearly they didn't get very well tested. Linus