Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbdFUTZo (ORCPT ); Wed, 21 Jun 2017 15:25:44 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44132 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbdFUTZn (ORCPT ); Wed, 21 Jun 2017 15:25:43 -0400 Date: Wed, 21 Jun 2017 15:25:41 -0400 (EDT) Message-Id: <20170621.152541.1977800544203723274.davem@davemloft.net> To: joe@perches.com Cc: dvlasenk@redhat.com, linux-kernel@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes From: David Miller In-Reply-To: <1498072750.3337.4.camel@perches.com> References: <20170621162809.4305-1-dvlasenk@redhat.com> <1498072750.3337.4.camel@perches.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 21 Jun 2017 11:43:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 30 From: Joe Perches Date: Wed, 21 Jun 2017 12:19:10 -0700 > On Wed, 2017-06-21 at 18:28 +0200, Denys Vlasenko wrote: >> This function compiles to 147 bytes of machine code. 13 callsites. >> >> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that >> SCTP events are not happening on every packet. >> They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such. >> Does not look performance critical. > > Thanks. > > But: > >> diff --git a/net/sctp/ulpevent.c b/net/sctp/ulpevent.c > [] >> @@ -88,7 +88,7 @@ int sctp_ulpevent_is_notification(const struct sctp_ulpevent *event) >> /* Hold the association in case the msg_name needs read out of >> * the association. >> */ >> -static inline void sctp_ulpevent_set_owner(struct sctp_ulpevent *event, >> +static void sctp_ulpevent_set_owner(struct sctp_ulpevent *event, >> const struct sctp_association *asoc) >> { >> struct sctp_chunk *chunk = event->chunk; > > This now misaligns the next line after the inline removal. Agreed, the argument indenation must be fixed.