Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883AbdFUUFr (ORCPT ); Wed, 21 Jun 2017 16:05:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:59790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbdFUUFp (ORCPT ); Wed, 21 Jun 2017 16:05:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68007217C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Wed, 21 Jun 2017 21:05:38 +0100 From: Jonathan Cameron To: Fabrice Gasnier Cc: , , , , , , , , , , , , Subject: Re: [PATCH v2 1/8] dt-bindings: mfd: Add STM32 LPTimer binding Message-ID: <20170621210538.568b0440@kernel.org> In-Reply-To: <1498055415-31513-2-git-send-email-fabrice.gasnier@st.com> References: <1498055415-31513-1-git-send-email-fabrice.gasnier@st.com> <1498055415-31513-2-git-send-email-fabrice.gasnier@st.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2268 Lines: 72 On Wed, 21 Jun 2017 16:30:08 +0200 Fabrice Gasnier wrote: > Add documentation for STMicroelectronics STM32 Low-Power Timer binding. > > Signed-off-by: Fabrice Gasnier Looks sensible to me. Acked-by: Jonathan Cameron > --- > Changes in v2: > - Lee's comments: s/Low Power/Low-Power/, remove 0x in example, improve > properties descriptions > --- > .../devicetree/bindings/mfd/stm32-lptimer.txt | 48 ++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/stm32-lptimer.txt > > diff --git a/Documentation/devicetree/bindings/mfd/stm32-lptimer.txt b/Documentation/devicetree/bindings/mfd/stm32-lptimer.txt > new file mode 100644 > index 0000000..af859c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/stm32-lptimer.txt > @@ -0,0 +1,48 @@ > +STMicroelectronics STM32 Low-Power Timer > + > +The STM32 Low-Power Timer (LPTIM) is a 16-bit timer that provides several > +functions: > +- PWM output (with programmable prescaler, configurable polarity) > +- Quadrature encoder, counter > +- Trigger source for STM32 ADC/DAC (LPTIM_OUT) > + > +Required properties: > +- compatible: Must be "st,stm32-lptimer". > +- reg: Offset and length of the device's register set. > +- clocks: Phandle to the clock used by the LP Timer module. > +- clock-names: Must be "mux". > +- #address-cells: Should be '<1>'. > +- #size-cells: Should be '<0>'. > + > +Optional subnodes: > +- pwm: See ../pwm/pwm-stm32-lp.txt > +- counter: See ../iio/timer/stm32-lptimer-cnt.txt > +- trigger: See ../iio/timer/stm32-lptimer-trigger.txt > + > +Example: > + > + lptimer1: lptimer@40002400 { > + compatible = "st,stm32-lptimer"; > + reg = <0x40002400 0x400>; > + clocks = <&timer_clk>; > + clock-names = "mux"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pwm { > + compatible = "st,stm32-pwm-lp"; > + pinctrl-names = "default"; > + pinctrl-0 = <&lppwm1_pins>; > + }; > + > + trigger@0 { > + compatible = "st,stm32-lptimer-trigger"; > + reg = <0>; > + }; > + > + counter { > + compatible = "st,stm32-lptimer-counter"; > + pinctrl-names = "default"; > + pinctrl-0 = <&lptim1_in_pins>; > + }; > + };