Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbdFUUR1 (ORCPT ); Wed, 21 Jun 2017 16:17:27 -0400 Received: from gateway36.websitewelcome.com ([50.116.127.2]:43591 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbdFUUR0 (ORCPT ); Wed, 21 Jun 2017 16:17:26 -0400 Date: Wed, 21 Jun 2017 14:52:08 -0500 Message-ID: <20170621145208.Horde.eM1O3f5tAb_tIuGcYvFpDJZ@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Ethan Zhao Cc: Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev , LKML Subject: Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value References: <20170518172223.Horde.5kLLwxMJWThQKv0bAxTsk4D@gator4166.hostgator.com> <20170620212234.GA10957@embeddedgus> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dNlfd-0040RV-0u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:37186 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 52 Hi Ethan, Quoting Ethan Zhao : > Gustavo, > > The return value of ret_val seems used to check if the access to PHY/NVM > got its semaphore, generally speaking, it is needed for every PHY > access of this driver. > > Reviewed-by: Ethan Zhao > Thank you very much for the clarification. > On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva > wrote: >> Check return value from call to e1e_wphy(). This value is being >> checked during previous calls to function e1e_wphy() and it seems >> a check was missing here. >> >> Addresses-Coverity-ID: 1226905 >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c >> b/drivers/net/ethernet/intel/e1000e/ich8lan.c >> index 68ea8b4..d6d4ed7 100644 >> --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c >> +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c >> @@ -2437,6 +2437,8 @@ static s32 >> e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw) >> if (hw->phy.revision < 2) { >> e1000e_phy_sw_reset(hw); >> ret_val = e1e_wphy(hw, MII_BMCR, 0x3140); >> + if (ret_val) >> + return ret_val; >> } >> } >> >> -- >> 2.5.0 >> -- Gustavo A. R. Silva