Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbdFUVA7 (ORCPT ); Wed, 21 Jun 2017 17:00:59 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36592 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbdFUVA6 (ORCPT ); Wed, 21 Jun 2017 17:00:58 -0400 Subject: Re: [PATCH v2 2/2] soc: brcmstb: Add driver for DPFE To: Florian Fainelli , Markus Mayer Cc: Rob Herring , Mark Rutland , Gregory Fong , Markus Mayer , Broadcom Kernel List , Device Tree List , ARM Kernel List , Linux Kernel Mailing List References: <20170613223710.31719-1-code@mmayer.net> <20170613223710.31719-3-code@mmayer.net> <5b79dee6-bb84-30b3-1bb2-287b24d42534@gmail.com> <79cb33fc-cc6a-e79c-5e5c-af632e20dc76@gmail.com> From: Florian Fainelli Message-ID: Date: Wed, 21 Jun 2017 14:00:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <79cb33fc-cc6a-e79c-5e5c-af632e20dc76@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2124 Lines: 57 On 06/14/2017 02:32 PM, Florian Fainelli wrote: > On 06/14/2017 09:34 AM, Markus Mayer wrote: >> On 13 June 2017 at 17:03, Florian Fainelli wrote: >>> Hi Markus, >>> >>> On 06/13/2017 03:37 PM, Markus Mayer wrote: >>>> From: Markus Mayer >>>> >>>> This driver allows access to DRAM properties, such as the refresh rate, >>>> via the Broadcom STB DDR PHY Front End (DPFE). The refresh rate can be >>>> used as indirect indicator of the DRAM temperature. >>>> >>>> The driver also allows setting of the sampling interval. >>>> >>>> Signed-off-by: Markus Mayer >>>> --- >>>> MAINTAINERS | 8 + >>>> drivers/soc/bcm/brcmstb/Makefile | 2 +- >>>> drivers/soc/bcm/brcmstb/dpfe.c | 689 +++++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 698 insertions(+), 1 deletion(-) >>>> create mode 100644 drivers/soc/bcm/brcmstb/dpfe.c >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index f7d568b..04f0be6 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -2864,6 +2864,14 @@ S: Maintained >>>> F: Documentation/devicetree/bindings/cpufreq/brcm,stb-avs-cpu-freq.txt >>>> F: drivers/cpufreq/brcmstb* >>>> >>>> +BROADCOM STB SOC DPFE DRIVER >>>> +M: Markus Mayer >>>> +M: bcm-kernel-feedback-list@broadcom.com >>>> +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >>>> +S: Maintained >>>> +F: Documentation/devicetree/bindings/soc/bcm/brcm,dpfe-cpu.txt >>>> +F: drivers/misc/brcmstb-dpfe.c >>> >>> Just one nit: this should be drivers/soc/bcm/brcmstb/dpfe.c, other than >>> that, I just need an Ack from Rob on the binding, and I will queue this >>> up, thanks! >> >> Oops. Thanks for catching that. Would you like me to re-send or will >> you fix up that path on your end? > > I can fix it up if Rob is happy with the current binding, if you need to > resubmit, please fix that as well. Thanks! Can you respin a v2 with the MAINTAINERS file as well as the downstream kernel fixes that implement suspend/resume support? Thank you > -- Florian