Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531AbdFUVg7 (ORCPT ); Wed, 21 Jun 2017 17:36:59 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46706 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098AbdFUVg6 (ORCPT ); Wed, 21 Jun 2017 17:36:58 -0400 Date: Wed, 21 Jun 2017 17:36:55 -0400 (EDT) Message-Id: <20170621.173655.1945994342723484710.davem@davemloft.net> To: michael.j.dilmore@gmail.com Cc: jay.vosburgh@canonical.com, vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com Subject: Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c From: David Miller In-Reply-To: References: <1498068137-3550-1-git-send-email-michael.j.dilmore@gmail.com> <21644.1498070000@famine> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 21 Jun 2017 13:55:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 249 Lines: 7 From: Michael D Date: Wed, 21 Jun 2017 22:35:56 +0100 > How do we actually stop a null pointer being dereferenced here? Maybe that's why it's a BUG_ON(), there is no reasonable way to continue if the pointer is NULL.