Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752463AbdFUWHK (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Jun 2017 18:07:10 -0400
Received: from ozlabs.org ([103.22.144.67]:48443 "EHLO ozlabs.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752408AbdFUWHJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Jun 2017 18:07:09 -0400
Subject: Re: [PATCH 3/3] fsi/master-gpio: Add external mode
To: Joel Stanley <joel@jms.id.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Christopher Bostic <cbostic@linux.vnet.ibm.com>
References: <1497864405-26990-1-git-send-email-jk@ozlabs.org>
 <1497864405-26990-4-git-send-email-jk@ozlabs.org>
 <CACPK8XcVH19nYRP85T6rX1D3jd+1C4kr09DW3W_9kf1DJjj49Q@mail.gmail.com>
From: Jeremy Kerr <jk@ozlabs.org>
Message-ID: <a6a9f730-4e1a-6f57-7844-d2fe4dc03dc9@ozlabs.org>
Date: Thu, 22 Jun 2017 06:07:00 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CACPK8XcVH19nYRP85T6rX1D3jd+1C4kr09DW3W_9kf1DJjj49Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-AU
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 440
Lines: 18

Hi Joel,

>> +static ssize_t external_mode_show(struct device *dev,
>> +               struct device_attribute *attr, char *buf)
>> +{
>> +       struct fsi_master_gpio *master = dev_get_drvdata(dev);
>> +
>> +       return snprintf(buf, PAGE_SIZE - 1, "%u",
> 
> I gave this a spin on a machine today and noticed we're missing a
> newline there. Should this be "%u\n"?

Yep, that'd make things easier to read. v2 coming.

Cheers,


Jeremy