Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751940AbdFVBRi (ORCPT ); Wed, 21 Jun 2017 21:17:38 -0400 Received: from conssluserg-03.nifty.com ([210.131.2.82]:51820 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbdFVBRh (ORCPT ); Wed, 21 Jun 2017 21:17:37 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com v5M1HXBn016614 X-Nifty-SrcIP: [209.85.213.178] MIME-Version: 1.0 In-Reply-To: <20170615083622.16618-1-richard.genoud@gmail.com> References: <20170615083622.16618-1-richard.genoud@gmail.com> From: Masahiro Yamada Date: Thu, 22 Jun 2017 10:17:31 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: fix header installation under fakechroot environment To: Richard Genoud Cc: Nicolas Dichtel , Daniel Vetter , Russell King , Mark Salter , Michael Ellerman , Linux Kbuild mailing list , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 27 2017-06-15 17:36 GMT+09:00 Richard Genoud : > Since commit fcc8487d477a ("uapi: export all headers under uapi > directories") fakechroot make bindeb-pkg fails, mismatching files for > directories: > touch: cannot touch 'usr/include/video/uvesafb.h/.install': Not a > directory > > This due to a bug in fakechroot: > when using the function $(wildcard $(srcdir)/*/.) in a makefile, under a > fakechroot environment, not only directories but also files are > returned. > > To circumvent that, we are using the functions: > $(sort $(dir $(wildcard $(srcdir)/*/)))) > > And thanks to Yamada Masahiro who figured out the right > filter-out/patsubst order ! > > Fixes: fcc8487d477a ("uapi: export all headers under uapi directories") > Signed-off-by: Richard Genoud > --- Applied to linux-kbuild/fixes. Thanks! -- Best Regards Masahiro Yamada