Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007AbdFVGIm (ORCPT ); Thu, 22 Jun 2017 02:08:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26433 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989AbdFVGIh (ORCPT ); Thu, 22 Jun 2017 02:08:37 -0400 Date: Thu, 22 Jun 2017 09:08:10 +0300 From: Dan Carpenter To: Kalle Valo Cc: Jia-Ju Bai , David Miller , manish.chopra@cavium.com, rahul.verma@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct Message-ID: <20170622060809.jvnuewiicuwtlzb4@mwanda> References: <1497840533-4894-1-git-send-email-baijiaju1990@163.com> <20170620.133530.1607963470682255531.davem@davemloft.net> <87d19xooo0.fsf@purkki.adurom.net> <594A131F.9040300@163.com> <8737atv4pm.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8737atv4pm.fsf@kamboji.qca.qualcomm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 505 Lines: 13 We should probably add a might_sleep() to ioremap() to prevent these bugs in the future. This bug is eight years old. You can report it, but it's going to hard to get anyone to fix it. I sometimes ignore ancient bugs. On the other hand, netxen is fairly well supported so it doesn't hurt to try. I try to report bugs as soon as they are introduced. I report it to the author and CC the relevant list. If people don't respond to my email after a month then I complain again. regards, dan carpenter