Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbdFVGJZ (ORCPT ); Thu, 22 Jun 2017 02:09:25 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:45096 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbdFVGJW (ORCPT ); Thu, 22 Jun 2017 02:09:22 -0400 Subject: Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver To: Stephen Boyd , Arnd Bergmann CC: Santosh Shilimkar , Michael Turquette , , References: <20170620201249.145468-1-arnd@arndb.de> <20170621215053.GH4493@codeaurora.org> From: Tero Kristo Message-ID: Date: Thu, 22 Jun 2017 09:09:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170621215053.GH4493@codeaurora.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 23 On 22/06/17 00:50, Stephen Boyd wrote: > On 06/20, Arnd Bergmann wrote: >> CONFIG_COMPILE_TEST allows building a configuration without >> TI_SCI_PROTOCOL, which then fails to link: >> >> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe': >> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle' >> >> This makes it a hard dependency. Right now, that means we can't >> actually compile-test the driver unless ARCH_KEYSTONE is set as >> well, but we can fix that by allowing TI_MESSAGE_MANAGER to >> be selected for COMPILE_TEST as well. >> >> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support") >> Signed-off-by: Arnd Bergmann >> > > Looks ok to me. Tero? > Yeah, looks okay to me also, been traveling so sorry about the latency. Acked-by: Tero Kristo