Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752889AbdFVHXt (ORCPT ); Thu, 22 Jun 2017 03:23:49 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:58430 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbdFVHXr (ORCPT ); Thu, 22 Jun 2017 03:23:47 -0400 Date: Thu, 22 Jun 2017 09:22:49 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] drm/vc4: Wait for fences interruptibly in blocking mode. Message-ID: <20170622092249.31473903@bbrezillon> In-Reply-To: <20170621185002.28563-2-eric@anholt.net> References: <20170621185002.28563-1-eric@anholt.net> <20170621185002.28563-2-eric@anholt.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1163 Lines: 36 On Wed, 21 Jun 2017 11:50:00 -0700 Eric Anholt wrote: > We should allow SIGIO and things to interrupt us before we get to the > no-error stage of the commit process. This code is effectively copied > from drm_atomic_helper_commit(). > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_kms.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c > index bc6ecdc6f104..6b1ccea76243 100644 > --- a/drivers/gpu/drm/vc4/vc4_kms.c > +++ b/drivers/gpu/drm/vc4/vc4_kms.c > @@ -142,6 +142,16 @@ static int vc4_atomic_commit(struct drm_device *dev, > return ret; > } > > + if (!nonblock) { > + ret = drm_atomic_helper_wait_for_fences(dev, state, true); > + if (ret) { > + drm_atomic_helper_cleanup_planes(dev, state); > + kfree(c); > + up(&vc4->async_modeset); > + return ret; > + } > + } > + > for_each_plane_in_state(state, plane, new_state, i) { > if ((plane->state->fb != new_state->fb) && new_state->fb) { > struct drm_gem_cma_object *cma_bo =