Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbdFVIGl (ORCPT ); Thu, 22 Jun 2017 04:06:41 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:43193 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752827AbdFVIGg (ORCPT ); Thu, 22 Jun 2017 04:06:36 -0400 X-263anti-spam: X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 4 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: wmc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 7/7] ARM: dts: rockchip: add efuse device node for rk3228 To: Heiko Stuebner Cc: robh+dt@kernel.org, ulf.hansson@linaro.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, charles.chen@rock-chips.com, kevan.lan@rock-chips.com, huangtao@rock-chips.com, finley.xiao@rock-chips.com, david.wu@rock-chips.com, shawn.lin@rock-chips.com, chenjh@rock-chips.com, wmc@rock-chips.com References: <1498116055-20977-1-git-send-email-frank.wang@rock-chips.com> <1498116278-3791-1-git-send-email-frank.wang@rock-chips.com> <37478525.gTCCky7JDB@phil> From: Frank Wang Message-ID: Date: Thu, 22 Jun 2017 16:06:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <37478525.gTCCky7JDB@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1374 Lines: 60 Hi Heiko, On 2017/6/22 15:27, Heiko Stuebner wrote: > Hi Frank, > > Am Donnerstag, 22. Juni 2017, 15:24:38 CEST schrieb Frank Wang: >> From: Finley Xiao >> >> Add a efuse node in the device tree for the rk3228 SoC. >> >> Signed-off-by: Finley Xiao >> --- >> arch/arm/boot/dts/rk322x.dtsi | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi >> index bd7ef53..a8697fe 100644 >> --- a/arch/arm/boot/dts/rk322x.dtsi >> +++ b/arch/arm/boot/dts/rk322x.dtsi >> @@ -336,6 +336,23 @@ >> status = "disabled"; >> }; >> >> + efuse: efuse@11040000 { >> + compatible = "rockchip,rk322x-efuse"; > you wanted to update the compatible in the efuse driver + binding txt > and then here as well (aka rk3228-efuse). Sorry, I will fix it and resend these series soon. BR. Frank > > Heiko > >> + reg = <0x11040000 0x20>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + clocks = <&cru PCLK_EFUSE_256>; >> + clock-names = "pclk_efuse"; >> + >> + /* Data cells */ >> + efuse_id: id@7 { >> + reg = <0x7 0x10>; >> + }; >> + cpu_leakage: cpu_leakage@17 { >> + reg = <0x17 0x1>; >> + }; >> + }; >> + >> i2c0: i2c@11050000 { >> compatible = "rockchip,rk3228-i2c"; >> reg = <0x11050000 0x1000>; >> > > > >