Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752777AbdFVIJV (ORCPT ); Thu, 22 Jun 2017 04:09:21 -0400 Received: from mail.steve.org.uk ([80.68.84.102]:59238 "EHLO ssh.steve.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbdFVIJS (ORCPT ); Thu, 22 Jun 2017 04:09:18 -0400 Date: Thu, 22 Jun 2017 08:09:15 +0000 From: Steve Kemp To: Ethan Zhao Cc: Steve Kemp , linux-security-module@vger.kernel.org, LKML , Kees Cook , James Morris , "Serge E. Hallyn" Subject: Re: [PATCH] Moved module init-functions into the module. Message-ID: <20170622080915.GA2936@steve.org.uk> References: <20170622065540.GA32346@steve.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-added-header: steve.org.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 464 Lines: 19 On Thu Jun 22, 2017 at 16:02:30 +0800, Ethan Zhao wrote: > Seems you moved the initialization of security module to > late_initcall stage, that is not right. Thanks for the feedback. > For security modules, you should use security_initcall() macro to define > the init functions. Literally just a change like this? -late_initcall(yama_add_hooks); +security_initcall(yama_add_hooks); I'll submit v2 with that shortly, thanks. Steve --