Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbdFVIMK (ORCPT ); Thu, 22 Jun 2017 04:12:10 -0400 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:17844 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdFVIMH (ORCPT ); Thu, 22 Jun 2017 04:12:07 -0400 X-IronPort-AV: E=Sophos;i="5.39,372,1493708400"; d="scan'208";a="4018545" Subject: Re: [PATCH v5 0/2] drm: atmel-hlcdc: clut support To: Peter Rosin , CC: Boris Brezillon , David Airlie , , Alexandre Belloni , Daniel Vetter References: <1498107791-17450-1-git-send-email-peda@axentia.se> From: Nicolas Ferre Organization: microchip Message-ID: Date: Thu, 22 Jun 2017 10:12:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1498107791-17450-1-git-send-email-peda@axentia.se> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 54 On 22/06/2017 at 07:03, Peter Rosin wrote: > Hi! > > This series adds support for an 8-bit clut mode in the atmel-hlcdc > driver. > > Changes since v4: > > - Added .clut_offset for overlay2 at 0xe00 for sama5d4 (unconfirmed if 0xe00 > is the correct offset, but I'll eat my hat if it's not there). You hat is safe and so you are: I confirm that overlay2 clut is at 0xe00 based on an older datasheet. Regards, > The sama5d4 > overlay2 is indeed there, it is just AWOL in the current datasheet. > - Added Acked-by from Daniel on patch 2/2. > > Changes since v3: > > - Dropped ugly code (patches 2/3 and 3/3) for legacy fbdev interaction. > - Slit out the .set_property change to a patch of its own. > > Changes since v2: > > - Fix mapping to the clut registers. > > Changes since v1: > > - Move the clut update from atmel_hlcdc_crtc_mode_valid to > atmel_hlcdc_plane_atomic_update. > - Add default .gamma_set helper (drm_atomic_helper_legacy_gamma_set). > - Don't keep a spare copy of the clut, reuse gamma_store instead. > - Don't try to synchronize the legacy fb clut with the drm clut. > > Cheers, > peda > > Peter Rosin (2): > drm: atmel-hlcdc: add missing .set_property helper to the crtc > drm: atmel-hlcdc: add support for 8-bit color lookup table mode > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 5 +++++ > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 14 ++++++++++++ > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 16 ++++++++++++++ > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 29 +++++++++++++++++++++++++ > 4 files changed, 64 insertions(+) > -- Nicolas Ferre